Bug 128870

Summary:

HTMLTextFormControlElement::subtreeHasChanged should be called before updating selection

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, ap, darin, enrica, kling, koivisto

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Cleanup	none

Description Ryosuke Niwa 2014-02-15 01:54:47 PST

In order to resolve the bug 128806, it's crucial to keep value() of HTMLTextFromControlElement's up-to-date
when FrameSelection::setSelection tries to update its selection caches.

Comment 1 Ryosuke Niwa 2014-02-15 02:01:51 PST

Created attachment 224294 [details]
Cleanup

Comment 2 Ryosuke Niwa 2014-02-15 03:21:08 PST

Turns out we don't need this change for the bug 128806 but this is probably a good refactoring anyways.

Comment 3 Ryosuke Niwa 2014-02-15 16:31:22 PST

Comment on attachment 224294 [details]
Cleanup

Clearing flags on attachment: 224294

Committed r164183: <http://trac.webkit.org/changeset/164183>

Comment 4 Ryosuke Niwa 2014-02-15 16:31:24 PST

All reviewed patches have been landed.  Closing bug.