| Summary: | Baseline JIT should have a fast path to bypass the write barrier on op_enter | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fpizlo | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Mark Hahnenberg
2014-02-14 11:46:07 PST
Created attachment 224241 [details]
Patch
Committed r164128: <http://trac.webkit.org/changeset/164128> Comment on attachment 224241 [details]
Patch
Shouldn't we check the remembered set bit instead?
Many functions will be old, and checking the mark bit won't save anything for old objects.
(In reply to comment #3) > (From update of attachment 224241 [details]) > Shouldn't we check the remembered set bit instead? > > Many functions will be old, and checking the mark bit won't save anything for old objects. The thinking was that if you're in the baseline JIT you might still be young, but I think checking the remembered set bit as well is an improvement. |