Bug 128832

Summary: Baseline JIT should have a fast path to bypass the write barrier on op_enter
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Mark Hahnenberg
Reported 2014-02-14 11:46:07 PST
<rdar://problem/16072244>
Attachments
Patch (4.68 KB, patch)
2014-02-14 12:06 PST, Mark Hahnenberg 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-02-14 12:06:25 PST
Created attachment 224241 [details] Patch
Mark Hahnenberg
Comment 2 2014-02-14 13:12:49 PST
Committed r164128: <http://trac.webkit.org/changeset/164128>
Geoffrey Garen
Comment 3 2014-02-14 13:14:50 PST
Comment on attachment 224241 [details] Patch Shouldn't we check the remembered set bit instead? Many functions will be old, and checking the mark bit won't save anything for old objects.
Mark Hahnenberg
Comment 4 2014-02-14 13:25:22 PST
(In reply to comment #3) > (From update of attachment 224241 [details]) > Shouldn't we check the remembered set bit instead? > > Many functions will be old, and checking the mark bit won't save anything for old objects. The thinking was that if you're in the baseline JIT you might still be young, but I think checking the remembered set bit as well is an improvement.
Note You need to log in before you can comment on or make changes to this bug.