Bug 128829

Summary: Web Replay: AtomicString replay input names should be stored in a thread-local table
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebCore Misc.Assignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ddkilzer, joepeck, kling, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch kling: review+

Blaze Burg
Reported 2014-02-14 11:05:17 PST
This makes it extremely cheap to check type tags of inputs in an extensible way (i.e., inputs can be in any framework). It also makes it cheap to deserialize replay sessions from disk, and will let us devirtualize input dispatch methods eventually.
Attachments
patch (11.79 KB, patch)
2014-02-14 12:03 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
patch (15.00 KB, patch)
2014-02-14 14:00 PST, Blaze Burg 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2014-02-14 12:03:45 PST
Created attachment 224239 [details] patch
Blaze Burg
Comment 2 2014-02-14 14:00:09 PST
Created attachment 224249 [details] patch
Andreas Kling
Comment 3 2014-02-14 14:05:55 PST
Comment on attachment 224249 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=224249&action=review r=me > Source/WebCore/replay/ReplayInputTypes.cpp:43 > + { > + UNUSED_PARAM(dummy); > + } Indentation looks off here.
Blaze Burg
Comment 4 2014-02-14 16:49:25 PST
Committed r164144: <http://trac.webkit.org/changeset/164144>
Note You need to log in before you can comment on or make changes to this bug.