Bug 128829

Summary: Web Replay: AtomicString replay input names should be stored in a thread-local table
Product: WebKit Reporter: BJ Burg <bburg>
Component: WebCore Misc.Assignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ddkilzer, joepeck, kling, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch kling: review+

Description BJ Burg 2014-02-14 11:05:17 PST 
This makes it extremely cheap to check type tags of inputs in an extensible way (i.e., inputs can be in any framework). It also makes it cheap to deserialize replay sessions from disk, and will let us devirtualize input dispatch methods eventually.
Comment 1 BJ Burg 2014-02-14 12:03:45 PST 
Created attachment 224239 [details]
patch
Comment 2 BJ Burg 2014-02-14 14:00:09 PST 
Created attachment 224249 [details]
patch
Comment 3 Andreas Kling 2014-02-14 14:05:55 PST 
Comment on attachment 224249 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224249&action=review

r=me

> Source/WebCore/replay/ReplayInputTypes.cpp:43
> +    {
> +        UNUSED_PARAM(dummy);
> +    }

Indentation looks off here.
Comment 4 BJ Burg 2014-02-14 16:49:25 PST 
Committed r164144: <http://trac.webkit.org/changeset/164144>