Summary: | [EFL][WK2] Stop calling mktemp(3). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||
Component: | New Bugs | Assignee: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, sergio | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Raphael Kubo da Costa (:rakuco)
2014-02-14 10:41:28 PST
Created attachment 224231 [details]
Patch
Attachment 224231 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 224231 [details] did not pass style-queue: > > > ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp:32: Alphabetical sorting problem. [build/include_order] [4] This is unrelated and should be ignored: those sys/* includes are normally expected to come before the other ones. Comment on attachment 224231 [details]
Patch
It looks this is more secure than before. LGTM
Committed r164179: <http://trac.webkit.org/changeset/164179> |