Bug 128819

Summary:

[ASan] Disable JSStack::sanitizeStack() to avoid false-positive stack-buffer-overflow errors

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

JavaScriptCore

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dfarler, fpizlo, ggaren

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=140130

Attachments:

Description	Flags
Patch for landing	none

Description David Kilzer (:ddkilzer) 2014-02-14 09:03:15 PST

When building with the clang address sanitizer, don't sanitize the stack since it will trigger false-positive stack-buffer-overflow errors.  Disabling this only results in a performance penalty, not a correctness penalty.

Comment 1 David Kilzer (:ddkilzer) 2014-02-14 09:05:43 PST

Created attachment 224221 [details]
Patch for landing

Comment 2 David Kilzer (:ddkilzer) 2014-02-14 09:06:30 PST

<rdar://problem/16055903>

Comment 3 David Kilzer (:ddkilzer) 2014-02-14 09:07:00 PST

Committed r164102: <http://trac.webkit.org/changeset/164102>