Bug 128819

Summary: [ASan] Disable JSStack::sanitizeStack() to avoid false-positive stack-buffer-overflow errors
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: dfarler, fpizlo, ggaren
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=140130
Attachments:
Description Flags
Patch for landing none

David Kilzer (:ddkilzer)
Reported 2014-02-14 09:03:15 PST
When building with the clang address sanitizer, don't sanitize the stack since it will trigger false-positive stack-buffer-overflow errors. Disabling this only results in a performance penalty, not a correctness penalty.
Attachments
Patch for landing (1.69 KB, patch)
2014-02-14 09:05 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2014-02-14 09:05:43 PST
Created attachment 224221 [details] Patch for landing
David Kilzer (:ddkilzer)
Comment 2 2014-02-14 09:06:30 PST
<rdar://problem/16055903>
David Kilzer (:ddkilzer)
Comment 3 2014-02-14 09:07:00 PST
Committed r164102: <http://trac.webkit.org/changeset/164102>
Note You need to log in before you can comment on or make changes to this bug.