Bug 128817

Summary: Get rid of redundant Platform.h includes
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2014-02-14 07:49:41 PST
wtf/Platform.h is included by config.h and config.h must be the first include in all cpp file. There is no reason to include Platform.h anywhere just for fun.
Attachments
Patch (105.03 KB, patch)
2014-02-14 07:52 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (104.92 KB, patch)
2014-02-17 03:47 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-02-14 07:52:12 PST
Created attachment 224213 [details] Patch
WebKit Commit Bot
Comment 2 2014-02-14 07:54:24 PST
Attachment 224213 [details] did not pass style-queue: ERROR: Source/WebKit2/config.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 3 2014-02-17 03:47:14 PST
Created attachment 224353 [details] Patch
WebKit Commit Bot
Comment 4 2014-02-17 03:49:13 PST
Attachment 224353 [details] did not pass style-queue: ERROR: Source/WebKit2/config.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/API/tests/JSNodeList.c:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/JavaScriptCore/API/tests/JSNode.c:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 5 2014-02-19 11:32:09 PST
Comment on attachment 224353 [details] Patch r=me. Please keep an eye on the builders in case there is some variation in build behavior based on OS revision or other local settings. Do you see any change in build efficiency with this change?
Csaba Osztrogonác
Comment 6 2014-02-20 03:28:01 PST
Comment on attachment 224353 [details] Patch Clearing flags on attachment: 224353 Committed r164424: <http://trac.webkit.org/changeset/164424>
Csaba Osztrogonác
Comment 7 2014-02-20 03:28:07 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 8 2014-02-20 05:36:31 PST
(In reply to comment #5) > (From update of attachment 224353 [details]) > r=me. Please keep an eye on the builders in case there is some variation in build behavior based on OS revision or other local settings. I watched the bots, all of them are happy now, except the GTK WK2 tester bot. There are crashes on it, but it doesn't provide any information about crashes. :( I'll investigate it. > Do you see any change in build efficiency with this change? I haven't seen any significant build time progression,
Csaba Osztrogonác
Comment 9 2014-02-20 05:45:56 PST
GTK bot reported false alarm, it is happy now: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/45025
Note You need to log in before you can comment on or make changes to this bug.