Summary: | CORS: Fix the handling of redirected request containing Origin null. | ||
---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> |
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | ap, bfulgham, buildbot, cdumez, commit-queue, gquan, japhet, rniwa |
Priority: | P2 | Keywords: | BlinkMergeCandidate |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 116075 | ||
Bug Blocks: | |||
Attachments: |
Description
youenn fablet
2014-02-14 07:38:30 PST
Created attachment 224215 [details]
Patch
Comment on attachment 224215 [details] Patch Attachment 224215 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5238515575029760 New failing tests: http/tests/xmlhttprequest/redirect-cors-origin-null.html Created attachment 224222 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 224215 [details] Patch Attachment 224215 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5712387772514304 New failing tests: http/tests/xmlhttprequest/redirect-cors-origin-null.html Created attachment 224224 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 224215 [details] Patch Attachment 224215 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5573610399858688 New failing tests: http/tests/xmlhttprequest/redirect-cors-origin-null.html Created attachment 224228 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Patch is failing (In reply to comment #6) > (From update of attachment 224215 [details]) > Attachment 224215 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.appspot.com/results/5573610399858688 > > New failing tests: > http/tests/xmlhttprequest/redirect-cors-origin-null.html Test is failing due to mac port network layer inserting "Accept-Encoding" header which then makes cross origin not simple. The preflight check fails as "Accept-Encoding" is not authorized. Patch in https://bugs.webkit.org/show_bug.cgi?id=116075 clears the "Accept-Encoding" header in case of a cross-origin request triggered from a redirect response. This should take care of the failing test. Created attachment 268962 [details]
Rebasing
Comment on attachment 268962 [details]
Rebasing
r=me.Please confirm the win and gtk-wk2 EWS bots are green, then you can land.
Comment on attachment 268962 [details] Rebasing Clearing flags on attachment: 268962 Committed r195100: <http://trac.webkit.org/changeset/195100> All reviewed patches have been landed. Closing bug. |