Summary: | [CSS Regions] The box decorations of an element overflowing a region should be clipped at the border box, not the content box | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Radu Stavila <stavila> | ||||||||
Component: | CSS | Assignee: | Radu Stavila <stavila> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker | ||||||||
Priority: | P2 | Keywords: | AdobeTracked | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 57312 | ||||||||||
Attachments: |
|
Description
Radu Stavila
2014-02-14 07:05:39 PST
Created attachment 224368 [details]
Patch
Comment on attachment 224368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224368&action=review > Source/WebCore/rendering/RenderRegion.cpp:525 > mappedRect.intersect(flowThreadPortionRect()); I think the correct order of operations is to expand the flowThreadPortionRect() with the paddings and then intersect. This way: 1. You expand only when actually clipping 2. You don't expand a rectangle already intersected with the flowThreadPortionRect() that doesn't need the extra space to display correctly. > Source/WebCore/rendering/RenderRegion.cpp:533 > + if (isFirstRegion()) { This should be startRegion. > Source/WebCore/rendering/RenderRegion.cpp:543 > + if (isLastRegion()) { This should be lastRegion. Created attachment 224377 [details]
Patch
Comment on attachment 224377 [details]
Patch
r=me. Before committing, please update the CL with the new helper you implemented. Thanks!
Created attachment 224381 [details]
Patch for landing
Comment on attachment 224381 [details] Patch for landing Clearing flags on attachment: 224381 Committed r164231: <http://trac.webkit.org/changeset/164231> |