Bug 128803

Summary: Mac port uses ANGLE_instanced_arrays related apis through those in GraphicsContext3DCommon.cpp
Product: WebKit Reporter: ChangSeok Oh <changseok>
Component: WebGLAssignee: ChangSeok Oh <changseok>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, commit-queue, dino, kondapallykalyan, noam, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
dino: review+, commit-queue: commit-queue-
Patch none

ChangSeok Oh
Reported 2014-02-14 00:57:55 PST
SSIA
Attachments
Patch (6.00 KB, patch)
2014-02-14 01:09 PST, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (6.00 KB, patch)
2014-02-14 02:03 PST, ChangSeok Oh 		dino: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (5.99 KB, patch)
2014-02-21 17:37 PST, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2014-02-14 01:09:11 PST
Created attachment 224178 [details] Patch
ChangSeok Oh
Comment 2 2014-02-14 02:03:57 PST
Created attachment 224181 [details] Patch
WebKit Commit Bot
Comment 3 2014-02-21 16:21:53 PST
Comment on attachment 224181 [details] Patch Rejecting attachment 224181 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 224181, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp Hunk #1 FAILED at 238. Hunk #2 FAILED at 253. Hunk #3 FAILED at 269. 3 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp.rej patching file Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6482028195217408
ChangSeok Oh
Comment 4 2014-02-21 17:37:44 PST
Created attachment 224934 [details] Patch
ChangSeok Oh
Comment 5 2014-02-21 19:16:53 PST
Comment on attachment 224934 [details] Patch Thanks!
WebKit Commit Bot
Comment 6 2014-02-21 19:48:33 PST
Comment on attachment 224934 [details] Patch Clearing flags on attachment: 224934 Committed r164524: <http://trac.webkit.org/changeset/164524>
ChangSeok Oh
Comment 7 2016-04-06 21:39:34 PDT
Close.
Note You need to log in before you can comment on or make changes to this bug.