Bug 128783 – Web Inspector: DataGrid should have an API to set sort column and direction

• Component: Web Inspector
• Status: RESOLVED FIXED

[Blaze Burg]

Some tables (such as DOMStorageView) should have a default sort column rather than displaying rows in a possibly undefined order. However, the code to update the actual sort column and direction is stuck within a click event handler.

[Radar WebKit Bug Importer]

<rdar://problem/16066438>

[Blaze Burg]

Created attachment 226446 [details]
the patch

[Timothy Hatcher]

Comment on attachment 226446 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226446&action=review

> Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js:204
> +        switch (this._dataGrid.sortColumnIdentifier || "url") {
> +            case "url": comparator = localeCompare.bind(this, "url"); break;

Just use default:?

> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:82
> +            var columns = { name: {}, value: {}, domain: {}, path: {}, expires: {}, size: {}, http: {}, secure: {}};

No space after {.

> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:141
> +            };
> +            if (cookie.type !== WebInspector.CookieType.Request)

Add a newline.

[Blaze Burg]

Committed r165487: <http://trac.webkit.org/changeset/165487>