Summary: | Web Inspector: DataGrid should have an API to set sort column and direction | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | joepeck, timothy, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
BJ Burg
2014-02-13 17:42:40 PST
Created attachment 226446 [details]
the patch
Comment on attachment 226446 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=226446&action=review > Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js:204 > + switch (this._dataGrid.sortColumnIdentifier || "url") { > + case "url": comparator = localeCompare.bind(this, "url"); break; Just use default:? > Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:82 > + var columns = { name: {}, value: {}, domain: {}, path: {}, expires: {}, size: {}, http: {}, secure: {}}; No space after {. > Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:141 > + }; > + if (cookie.type !== WebInspector.CookieType.Request) Add a newline. Committed r165487: <http://trac.webkit.org/changeset/165487> |