Bug 128780

Summary:

DumpRenderTree fails to build: Perl support module building for OS X but linking for the simulator

Product:

WebKit

Reporter:

David Farler <dfarler>

Component:

Tools / Tests

Assignee:

David Farler <dfarler>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, ddkilzer, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

All

Attachments:

Description	Flags
Patch	simon.fraser: review+

David Farler

Reported 2014-02-13 17:35:34 PST

In https://bugs.webkit.org/show_bug.cgi?id=127694 , I removed the TOOLCHAINS= erasure at the command line in my effort to clean up the Makefile one level up, and the xcrun --sdk $ENV{SDKROOT} -find clang took over, going again back to the simulator toolchain's compiler. However, all Perl modules are tagged with the OS X platform as far as load commands are concerned, so that isn't going to work. Instead of putting the TOOLCHAINS= erasure back, let's just use xcrun -find clang to search for the compiler, which will find a suitable OS X one.

Attachments
Patch (1.58 KB, patch) 2014-02-13 17:38 PST, David Farler	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Farler

Comment 1 2014-02-13 17:38:56 PST

Created attachment 224135 [details] Patch

David Farler

Comment 2 2014-02-13 17:44:16 PST

Committed r164082: <http://trac.webkit.org/changeset/164082>

Daniel Bates

Comment 3 2014-02-21 12:59:28 PST

(In reply to comment #2) > Committed r164082: <http://trac.webkit.org/changeset/164082> This didn't fix for me when performing a clean build of DumpRenderTree. See bug #129163.

Daniel Bates

Comment 4 2014-02-21 13:00:09 PST

(In reply to comment #3) > (In reply to comment #2) > > Committed r164082: <http://trac.webkit.org/changeset/164082> > > This didn't fix for me when performing a clean build of DumpRenderTree. See bug #129163. *This didn't fix the build error for me

Note You need to log in before you can comment on or make changes to this bug.