Summary: | Gdk improvements | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Krzysztof Kowalczyk <kkowalczyk> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Krzysztof Kowalczyk
2007-02-23 23:21:08 PST
Created attachment 13357 [details]
Gdk improvements
* fix a crash caused by freeing memory we don't own
* only scroll on keydown, not both keydown and keyup
* improve gdklauncher by adding text field for entering url
Comment on attachment 13357 [details]
Gdk improvements
+ StringImpl *txt = new StringImpl("Welcome to Gdk Web Browser");
I know this is commented out, but you can just allocate this on the stack.
#include "PlatformString.h"
+#include "ResourceHandleManager.h"
No need for the newline between these two.
+ if (!str || !*str)
+ return true;
+ return false;
This can just be:
return !str || !*str;
if (0 == strcmp(str1, str2))
- return 1;
- return 0;
+ return true;
+ return false;
Similar comment here.
+ GtkWidget *topLevelWindow = gtk_window_new(GTK_WINDOW_TOPLEVEL);
You've got a misplaced * here.
+ gFrame = new FrameGdk(page, 0, frameLoaderClient);
This can also be on the stack.
r=me
|