Bug 128715

Summary: [WK2][iOS] Add WKContentObservation support when dispatching synthetic mouse events
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, darin, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion none

Benjamin Poulain
Reported 2014-02-12 18:12:35 PST
[WK2][iOS] Add WKContentObservation support when dispatching synthetic mouse events
Attachments
Patch (2.20 KB, patch)
2014-02-12 18:12 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (638.97 KB, application/zip)
2014-02-13 05:46 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-02-12 18:12:54 PST
Created attachment 224039 [details] Patch
Darin Adler
Comment 2 2014-02-12 19:39:32 PST
Comment on attachment 224039 [details] Patch Why do we need this around moved, but not around press or release?
Benjamin Poulain
Comment 3 2014-02-12 19:42:43 PST
(In reply to comment #2) > (From update of attachment 224039 [details]) > Why do we need this around moved, but not around press or release? The idea is to not send the synthetic mousedown-mouseup and click if there is a menu. WKContentObservation detects style changes on mousemove/mouseover/mouseenter. If there is a stylechange, we assume there is a "hover" action and avoid sending more events.
Build Bot
Comment 4 2014-02-13 05:46:51 PST
Comment on attachment 224039 [details] Patch Attachment 224039 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6266005969960960 New failing tests: transitions/extra-transition.html
Build Bot
Comment 5 2014-02-13 05:46:54 PST
Created attachment 224060 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Benjamin Poulain
Comment 6 2014-02-14 12:50:50 PST
Comment on attachment 224039 [details] Patch Clearing flags on attachment: 224039 Committed r164121: <http://trac.webkit.org/changeset/164121>
Benjamin Poulain
Comment 7 2014-02-14 12:50:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.