Bug 128639

Summary:

[WK2][iOS] Add back the special viewport for the old xhtml mobile doctype

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, japhet, kangil.han

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Benjamin Poulain 2014-02-11 17:20:41 PST

[WK2][iOS] Add back the special viewport for the old xhtml mobile doctype

Comment 1 Benjamin Poulain 2014-02-11 17:25:05 PST

Created attachment 223921 [details]
Patch

Comment 2 Andreas Kling 2014-02-12 10:56:26 PST

Comment on attachment 223921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223921&action=review

r=me, thanks for fixing this! (I was the one who removed the doctype stuff..)

> Source/WebCore/dom/Document.cpp:801
> +    page()->chrome().didReceiveDocType(frame());

Since this code doesn't actually check that a doctype tag is present, maybe we should have a comment about why.
It's also not obvious why this is restricted to PLATFORM(IOS).

> Source/WebCore/page/Chrome.cpp:609
> +    if (DocumentType* documentType = frame->document()->doctype())

I'd harmfully consider auto* here.

Comment 3 Benjamin Poulain 2014-02-12 13:39:23 PST

Committed r163980: <http://trac.webkit.org/changeset/163980>