Bug 128636

Summary:

IDB: Reimport storage/indexeddb tests from Blink

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit2

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, commit-queue, jsbell, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

128645

Bug Blocks:

Attachments:

Description	Flags
Patch v1 - Bulk import of all non-mozilla tests (all these tests are still skipped anyways)	none
Patch v2 - Pretty much the same import, except this time the Mozilla tests pass on WebKit with new expectations.	jer.noble: review+

Description Brady Eidson 2014-02-11 17:03:44 PST

IDB: Re-import storage/indexeddb tests from Blink

Many have been updated for changes in the spec, many are more verbose, and there are some new ones.

Starting with this newer clean slate will make it easier to start wading through the failures.

Comment 1 Brady Eidson 2014-02-11 17:07:15 PST

Created attachment 223917 [details]
Patch v1 - Bulk import of all non-mozilla tests (all these tests are still skipped anyways)

Comment 2 WebKit Commit Bot 2014-02-11 17:51:10 PST

Comment on attachment 223917 [details]
Patch v1 - Bulk import of all non-mozilla tests (all these tests are still skipped anyways)

Clearing flags on attachment: 223917

Committed r163923: <http://trac.webkit.org/changeset/163923>

Comment 3 WebKit Commit Bot 2014-02-11 17:51:11 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Ryosuke Niwa 2014-02-11 19:09:07 PST

9 of these imported tests are failing on ML:

http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r163925%20(15902)/results.html

Comment 5 Brady Eidson 2014-02-11 19:23:37 PST

(In reply to comment #4)
> 9 of these imported tests are failing on ML:
> 
> http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r163925%20(15902)/results.html

By design, none of them should run because their directories are skipped.  Taking a look...

Comment 6 Brady Eidson 2014-02-11 19:24:32 PST

(In reply to comment #5)
> (In reply to comment #4)
> > 9 of these imported tests are failing on ML:
> > 
> > http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r163925%20(15902)/results.html
> 
> By design, none of them should run because their directories are skipped.  Taking a look...

The mozilla tests do run, and their behavior changed...  even though I didn't import the new versions of them.  A dependency I must've missed.

I'll just roll out for now.

Comment 7 WebKit Commit Bot 2014-02-11 19:27:49 PST

Re-opened since this is blocked by bug 128645

Comment 8 Brady Eidson 2014-02-12 09:52:46 PST

Created attachment 223976 [details]
Patch v2 - Pretty much the same import, except this time the Mozilla tests pass on WebKit with new expectations.

Comment 9 Jer Noble 2014-02-12 10:05:15 PST

Comment on attachment 223976 [details]
Patch v2 - Pretty much the same import, except this time the Mozilla tests pass on WebKit with new expectations.

rs=me.

Comment 10 Brady Eidson 2014-02-12 10:13:20 PST

http://trac.webkit.org/changeset/163963