| Summary: | Inserting a node with a codeOrigin "like" another node should copy both the codeOrigin and codeOriginForExitTarget | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, rniwa, sam | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 125433 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Filip Pizlo
2014-02-11 16:42:26 PST
I suspect that the best way to do this is to have the Node constructor somehow take both codeOrigins, so if you really want to copy the codeOrigin from one node as both the codeOrigin and codeOriginForExitTarget, then you have to say that explicitly. Created attachment 223924 [details]
work in progress
Created attachment 223926 [details]
more!
Created attachment 223927 [details]
the patch
Attachment 223927 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGGraph.cpp:349: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
Total errors found: 1 in 41 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 223927 [details]
the patch
r=me.
Landed in http://trac.webkit.org/changeset/163946 I broke the debug build. Fix on the way. Fixed debug build in http://trac.webkit.org/changeset/163948. |