Bug 128635

Summary:

Inserting a node with a codeOrigin "like" another node should copy both the codeOrigin and codeOriginForExitTarget

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, rniwa, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

125433

Attachments:

Description	Flags
work in progress	none
more!	none
the patch	msaboff: review+

Filip Pizlo

Reported 2014-02-11 16:42:26 PST

Patch forthcoming.

Attachments
work in progress (70.67 KB, patch) 2014-02-11 17:45 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
more! (163.45 KB, patch) 2014-02-11 18:34 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (185.89 KB, patch) 2014-02-11 18:45 PST, Filip Pizlo	msaboff: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2014-02-11 16:43:20 PST

I suspect that the best way to do this is to have the Node constructor somehow take both codeOrigins, so if you really want to copy the codeOrigin from one node as both the codeOrigin and codeOriginForExitTarget, then you have to say that explicitly.

Filip Pizlo

Comment 2 2014-02-11 17:45:28 PST

Created attachment 223924 [details] work in progress

Filip Pizlo

Comment 3 2014-02-11 18:34:50 PST

Created attachment 223926 [details] more!

Filip Pizlo

Comment 4 2014-02-11 18:45:08 PST

Created attachment 223927 [details] the patch

WebKit Commit Bot

Comment 5 2014-02-11 18:47:14 PST

Attachment 223927 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGGraph.cpp:349: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 1 in 41 files If any of these errors are false positives, please file a bug against check-webkit-style.

Michael Saboff

Comment 6 2014-02-11 20:53:16 PST

Comment on attachment 223927 [details] the patch r=me.

Filip Pizlo

Comment 7 2014-02-11 21:38:07 PST

Landed in http://trac.webkit.org/changeset/163946

Filip Pizlo

Comment 8 2014-02-11 21:48:11 PST

I broke the debug build. Fix on the way.

Ryosuke Niwa

Comment 9 2014-02-11 21:49:37 PST

Fixed debug build in http://trac.webkit.org/changeset/163948.

Note You need to log in before you can comment on or make changes to this bug.