Bug 128614

Summary: [New Multicolumn] getClientRects returns wrong rectangle
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+

Dave Hyatt
Reported 2014-02-11 11:22:12 PST
Make sure getClientRects is as good as the old multicolumn code. The old code returned the column that contained the center point of the content, so that's what we do. Eventually we should return multiple rectangles, but for now this at least gives us parity with the region code and the old multicolumn code.
Attachments
Patch (70.39 KB, patch)
2014-02-11 11:24 PST, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (110.51 KB, patch)
2014-02-11 13:20 PST, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (109.18 KB, patch)
2014-02-11 13:23 PST, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2014-02-11 11:24:27 PST
Created attachment 223884 [details] Patch
Dave Hyatt
Comment 2 2014-02-11 13:20:44 PST
Created attachment 223892 [details] Patch
Dave Hyatt
Comment 3 2014-02-11 13:23:06 PST
Created attachment 223893 [details] Patch
Sam Weinig
Comment 4 2014-02-11 13:27:57 PST
Comment on attachment 223893 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223893&action=review > Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:180 > + return 0; We have been switching to nullptr in cases like this. > Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:192 > + return 0; We have been switching to nullptr in cases like this.
Dave Hyatt
Comment 5 2014-03-20 13:27:13 PDT
Fixed in r165991.
Note You need to log in before you can comment on or make changes to this bug.