Bug 128614

Summary: [New Multicolumn] getClientRects returns wrong rectangle
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+

Description Dave Hyatt 2014-02-11 11:22:12 PST 
Make sure getClientRects is as good as the old multicolumn code. The old code returned the column that contained the center point of the content, so that's what we do. Eventually we should return multiple rectangles, but for now this at least gives us parity with the region code and the old multicolumn code.
Comment 1 Dave Hyatt 2014-02-11 11:24:27 PST 
Created attachment 223884 [details]
Patch
Comment 2 Dave Hyatt 2014-02-11 13:20:44 PST 
Created attachment 223892 [details]
Patch
Comment 3 Dave Hyatt 2014-02-11 13:23:06 PST 
Created attachment 223893 [details]
Patch
Comment 4 Sam Weinig 2014-02-11 13:27:57 PST 
Comment on attachment 223893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223893&action=review

> Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:180
> +        return 0;

We have been switching to nullptr in cases like this.

> Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:192
> +        return 0;

We have been switching to nullptr in cases like this.
Comment 5 Dave Hyatt 2014-03-20 13:27:13 PDT 
Fixed in r165991.