Summary: | 'ar T' is not portable and breaks the build on FreeBSD | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Allison Lortie (desrt) <desrt> | ||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | berto, gustavo, landry, ryuan.choi, sergio, zan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 128598 | ||||||||
Attachments: |
|
Description
Allison Lortie (desrt)
2014-02-11 05:29:18 PST
Created attachment 223846 [details]
SetupLibtool.m4: use 'ar T' only on GNU ar
Created attachment 223848 [details]
Patch
The patch looks fine, here's the updated one with the changelog entry.
Thanks!
Committed r163954: <http://trac.webkit.org/changeset/163954> I know this has been fixed/commited, but as it was already sort-of fixed in https://bugs.webkit.org/show_bug.cgi?id=118732, couldnt you set AR_FLAGS=cru in the build environment to avoid having to patch autohell this way ? I don't think it should be expected to have to set an environment variable to prevent it from containing non-POSIX values... If anything, it should be the other way around. I think having this check can make everyone happy. (In reply to comment #5) > I don't think it should be expected to have to set an environment variable to prevent it from containing non-POSIX values... > > If anything, it should be the other way around. > > I think having this check can make everyone happy. I totally agree (and i'm happy with the check for OpenBSD too!), was just wondering about the reasoning - usually it's not so easy to get non-linux fixes in :) (In reply to comment #6) > I totally agree (and i'm happy with the check for OpenBSD too!), was > just wondering about the reasoning - usually it's not so easy to get > non-linux fixes in :) The solution proposed by Ryan looked just fine to me. And I've been pushing non-linux fixes for a long time btw :) |