Summary: | Frame::rectForSelection shouldn't instantiate FrameSelection | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, buildbot, darin, enrica, justin.garcia, mitz, psolanki, rniwa | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 127832 | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2014-02-11 01:19:39 PST
Created attachment 223827 [details]
Cleanup
Comment on attachment 223827 [details] Cleanup Attachment 223827 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5678939372519424 New failing tests: animations/stop-animation-on-suspend.html Created attachment 223841 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
> animations/stop-animation-on-suspend.html
Now, that's a lie.
Comment on attachment 223827 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=223827&action=review > Source/WebCore/editing/htmlediting.cpp:1278 > + // if caretNode is a block and caret is inside it then caret should be painted by that block Comment style. Comment on attachment 223827 [details] Cleanup (In reply to comment #5) > (From update of attachment 223827 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223827&action=review > > > Source/WebCore/editing/htmlediting.cpp:1278 > > + // if caretNode is a block and caret is inside it then caret should be painted by that block > > Comment style. WIll fix. Committed r163920: <http://trac.webkit.org/changeset/163920> |