Bug 128579

Summary:

Support ANGLE_instanced_arrays for GLES backend.

Product:

WebKit

Reporter:

ChangSeok Oh <changseok>

Component:

WebGL

Assignee:

ChangSeok Oh <changseok>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, gustavo, kondapallykalyan, mrobinson, noam, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

ChangSeok Oh

Reported 2014-02-10 21:45:39 PST

SSIA

Attachments
Patch (14.88 KB, patch) 2014-02-11 23:42 PST, ChangSeok Oh	no flags	Details Formatted Diff Diff
Patch (15.27 KB, patch) 2014-02-12 01:44 PST, ChangSeok Oh	no flags	Details Formatted Diff Diff
Patch (15.25 KB, patch) 2014-02-12 23:09 PST, ChangSeok Oh	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

ChangSeok Oh

Comment 1 2014-02-11 23:42:44 PST

Created attachment 223944 [details] Patch

WebKit Commit Bot

Comment 2 2014-02-11 23:44:19 PST

Attachment 223944 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1634: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:239: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:242: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:245: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:248: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:251: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:254: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 7 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

ChangSeok Oh

Comment 3 2014-02-12 01:44:34 PST

Created attachment 223956 [details] Patch

WebKit Commit Bot

Comment 4 2014-02-12 01:45:31 PST

Attachment 223956 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1634: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:239: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:243: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:245: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:246: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:247: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:248: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:252: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:256: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:258: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:259: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:260: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:261: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:262: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:266: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:270: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:272: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:273: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 18 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dean Jackson

Comment 5 2014-02-12 10:16:17 PST

Comment on attachment 223956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223956&action=review > Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:244 > + if (m_glDrawArraysInstancedANGLE) { > + m_context->makeContextCurrent(); > + m_glDrawArraysInstancedANGLE(mode, first, count, primcount); > + return; > + } > + > + m_context->synthesizeGLError(GL_INVALID_OPERATION); I think this should be the other way around. if (!m_glDrawArraysInstancedANGLE) { m_context->error.. return; } m_context->makeContextCurrent... e.g. early exit if error, otherwise do the real work. Same goes for the other two methods here.

ChangSeok Oh

Comment 6 2014-02-12 23:09:14 PST

Created attachment 224049 [details] Patch

ChangSeok Oh

Comment 7 2014-02-12 23:10:44 PST

Comment on attachment 223956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223956&action=review Thanks for the review! I'll land this after seeing all greens. >> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:244 >> + m_context->synthesizeGLError(GL_INVALID_OPERATION); > > I think this should be the other way around. > > if (!m_glDrawArraysInstancedANGLE) { > m_context->error.. > return; > } > > m_context->makeContextCurrent... > > e.g. early exit if error, otherwise do the real work. > > Same goes for the other two methods here. Done.

WebKit Commit Bot

Comment 8 2014-02-12 23:11:48 PST

Attachment 224049 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1634: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:239: Wrong number of spaces before statement. (expected: 4) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:243: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:245: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:246: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:247: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:248: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:252: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:256: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:258: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:259: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:260: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:261: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:262: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:266: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:270: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:272: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:273: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 18 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 9 2014-02-13 04:53:52 PST

Comment on attachment 224049 [details] Patch Clearing flags on attachment: 224049 Committed r164026: <http://trac.webkit.org/changeset/164026>

WebKit Commit Bot

Comment 10 2014-02-13 04:53:55 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.