Bug 128572 – O_CLOEXEC in shm_open does not work on FreeBSD

• Component: WebKit2
• Status: RESOLVED FIXED

[Ting-Wei Lan]

In Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp, line 110:
fileDescriptor = shm_open(tempName.data(), O_CREAT | O_CLOEXEC | O_RDWR, S_IRUSR | S_IWUSR);

The O_CLOEXEC flag causes the system call to fail with EINVAL (invalid arguments).

According to POSIX standard (http://pubs.opengroup.org/onlinepubs/9699919799/functions/shm_open.html), the O_CLOEXEC is not needed because the FD_CLOEXEC file descriptor flag is automatically set by shm_open.

I think we can just remove the O_CLOEXEC flag to fix the issue. This issue has caused all applications using WebKit2GTK+ on FreeBSD endlessly retrying shm_open.

[Alberto Garcia]

Created attachment 223820 [details]
Patch

I see, thanks for spotting this.

[Sergio Villar Senin]

Comment on attachment 223820 [details]
Patch

The change looks sensible to me. Let's go for it.

[Build Bot]

Comment on attachment 223820 [details]
Patch

Attachment 223820 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6477038114308096

New failing tests:
animations/stop-animation-on-suspend.html

[Build Bot]

Created attachment 223825 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[WebKit Commit Bot]

Comment on attachment 223820 [details]
Patch

Clearing flags on attachment: 223820

Committed r163875: <http://trac.webkit.org/changeset/163875>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.