Summary: | Removing limitation on JSLock’s lockDropDepth | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, fpizlo, ggaren, mhahnenberg, msaboff, oliver | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mark Lam
2014-02-10 18:03:42 PST
Created attachment 223785 [details]
the patch.
Comment on attachment 223785 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=223785&action=review > Source/JavaScriptCore/ChangeLog:8 > + Now that weâve switched to using the C stack, we no longer need to limit Will fix the non-ascii character. > Source/JavaScriptCore/ChangeLog:25 > + JSLock, yield, and the relock it again later before retrying the check. typo: “the relock” ==> “then relock”. Created attachment 223786 [details]
patch 2: fixed typos.
Created attachment 223787 [details]
patch 3: rebased, and fixed more typo fails.
Comment on attachment 223787 [details] patch 3: rebased, and fixed more typo fails. View in context: https://bugs.webkit.org/attachment.cgi?id=223787&action=review r=me > Source/JavaScriptCore/runtime/JSLock.h:117 > + friend class JSLock; Let's make the accessor functions public instead of making JSLock a friend. Thanks for the review. Landed in r163855: <http://trac.webkit.org/r163855>. |