Bug 128542 – Make the Identifier::add() family return PassRef<StringImpl>.

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Andreas Kling]

We should make Identifier::add() and friends return PassRef<StringImpl> since they are guaranteed to return non-null strings.
This will remove one null-check branch from Identifier's constructor.

[Andreas Kling]

Created attachment 223724 [details]
Patch

[WebKit Commit Bot]

Attachment 223724 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/Identifier.h:133:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/Identifier.h:134:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Comment on attachment 223724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223724&action=review

> Source/JavaScriptCore/runtime/Identifier.h:196
> +        return addResult.isNewEntry ? adoptRef(**addResult.iterator) : **addResult.iterator;

** :|

[WebKit Commit Bot]

Comment on attachment 223724 [details]
Patch

Clearing flags on attachment: 223724

Committed r163808: <http://trac.webkit.org/changeset/163808>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.