Bug 128531 – XMLHttpRequestUpload should support ontimeout event handler

• Component: XML
• Status: RESOLVED FIXED

[youenn fablet]

XMLHttpRequestUpload sends timeout event but has no ontimeout event handler.
We should add this handler as specified in http://www.w3.org/TR/XMLHttpRequest/#interface-xmlhttprequest

[youenn fablet]

Created attachment 223708 [details]
Added ontimeout in XHR upload IDL and Header

[Build Bot]

Comment on attachment 223708 [details]
Added ontimeout in XHR upload IDL and Header

Attachment 223708 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5109972169916416

New failing tests:
http/tests/xmlhttprequest/upload-ontimeout.html

[Build Bot]

Created attachment 223715 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[youenn fablet]

Created attachment 223819 [details]
Increased size of data to upload to hit timeout in the new test

[youenn fablet]

The patch is still valid and runs XHR tests fine (at least for GTK).
Anybody willing to review it?

[youenn fablet]

This patch still runs well on GTK and Mac.
It aligns with Blink and Firefox.

[youenn fablet]

Created attachment 265155 [details]
Patch

[Build Bot]

Comment on attachment 265155 [details]
Patch

Attachment 265155 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/409378

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/interfaces.html

[Build Bot]

Created attachment 265157 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 265155 [details]
Patch

Attachment 265155 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/409379

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/interfaces.html

[Build Bot]

Created attachment 265158 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[youenn fablet]

Created attachment 265159 [details]
Rebasing interfaces-expected.txt

[Chris Dumez]

Comment on attachment 265159 [details]
Rebasing interfaces-expected.txt

Shouldn't we actually call this event handler? What's the point of exposing it if we don't really support it?

[Chris Dumez]

Comment on attachment 265159 [details]
Rebasing interfaces-expected.txt

View in context: https://bugs.webkit.org/attachment.cgi?id=265159&action=review

> Source/WebCore/xml/XMLHttpRequestUpload.idl:40
> +    attribute EventHandler ontimeout;

This exposes the attribute but is never called from native side it seems. So why is this useful?

[youenn fablet]

> Shouldn't we actually call this event handler? What's the point of exposing
> it if we don't really support it?

upload.timeout event is supported in XMLHttpRequest::dispatchErrorEvents when passing timeout as event type.

> This exposes the attribute but is never called from native side it seems. So
> why is this useful?

The only missing thing is to expose it to user scripts.
It works well as can be seen from imported/w3c/web-platform-tests/XMLHttpRequest/send-timeout-events.htm which is now passing.

Is it sufficient?

[Chris Dumez]

Comment on attachment 265159 [details]
Rebasing interfaces-expected.txt

ok, thanks for clarifying.

[WebKit Commit Bot]

Comment on attachment 265159 [details]
Rebasing interfaces-expected.txt

Clearing flags on attachment: 265159

Committed r192256: <http://trac.webkit.org/changeset/192256>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.