Bug 128518

Summary: text-decoration-skip: ink skips incorrect position of Japanese text in vertical writing mode.
Product: WebKit Reporter: Yuki Sekiguchi <yuki.sekiguchi>
Component: Layout and RenderingAssignee: Myles C. Maxfield <mmaxfield>
Status: REOPENED    
Severity: Normal CC: dino, jonlee, mmaxfield, phiw2, rurumi663, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Reproduced content
none
Reproduced image
none
/Applications/Safari Technology Preview.app none

Yuki Sekiguchi
Reported 2014-02-09 22:47:01 PST
Created attachment 223674 [details] Reproduced content In the attached content, the underline of the character "日" should not skip. The underline of the character "本" should skip the slant line of the glyph, but it cross the slant line of the glyph. I attached reproduced image and drew red circles to wrong points.
Attachments
Reproduced content (579 bytes, text/html)
2014-02-09 22:47 PST, Yuki Sekiguchi 		no flags
Details
Reproduced image (97.06 KB, image/png)
2014-02-09 22:48 PST, Yuki Sekiguchi 		no flags
Details
/Applications/Safari Technology Preview.app (deleted)
2016-11-17 13:46 PST, rurumi663@gmail.com 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Yuki Sekiguchi
Comment 1 2014-02-09 22:48:22 PST
Created attachment 223675 [details] Reproduced image
Yuki Sekiguchi
Comment 2 2014-02-09 22:52:34 PST
I didn't read the code, but it looked like text-decoration-skip: ink code used horizontal glyph to calculate underline length.
Jon Lee
Comment 3 2014-02-09 22:59:42 PST
Looks to me that we're running the path intersection algorithm as if the underline were under the character, rather than on the left hand side.
Jon Lee
Comment 4 2014-02-09 23:00:12 PST
I just restated what Yuki said ^_^
Myles C. Maxfield
Comment 5 2014-02-10 12:50:55 PST
*** This bug has been marked as a duplicate of bug 128145 ***
Myles C. Maxfield
Comment 6 2014-02-10 13:45:26 PST
Reopened: even if bug 128145 is fixed, text-orientation: upright will cause this bad behavior to be shown
Myles C. Maxfield
Comment 7 2014-02-12 19:29:39 PST
Stop-gap band-aid patch until a real fix can be made: https://bugs.webkit.org/show_bug.cgi?id=128718
David Kilzer (:ddkilzer)
Comment 8 2016-09-09 10:25:37 PDT
<rdar://problem/28227563>
rurumi663@gmail.com
Comment 9 2016-11-17 13:46:07 PST
Created attachment 295079 [details] /Applications/Safari Technology Preview.app
Note You need to log in before you can comment on or make changes to this bug.