Bug 128518

Summary: text-decoration-skip: ink skips incorrect position of Japanese text in vertical writing mode.
Product: WebKit Reporter: Yuki Sekiguchi <yuki.sekiguchi>
Component: Layout and RenderingAssignee: Myles C. Maxfield <mmaxfield>
Status: REOPENED ---    
Severity: Normal CC: dino, jonlee, mmaxfield, phiw2, rurumi663, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Reproduced content
none
Reproduced image
none
/Applications/Safari Technology Preview.app none

Description Yuki Sekiguchi 2014-02-09 22:47:01 PST
Created attachment 223674 [details]
Reproduced content

In the attached content, the underline of the character "日" should not skip.
The underline of the character "本" should skip the slant line of the glyph, but it cross the slant line of the glyph.

I attached reproduced image and drew red circles to wrong points.
Comment 1 Yuki Sekiguchi 2014-02-09 22:48:22 PST
Created attachment 223675 [details]
Reproduced image
Comment 2 Yuki Sekiguchi 2014-02-09 22:52:34 PST
I didn't read the code, but it looked like text-decoration-skip: ink code used horizontal glyph to calculate underline length.
Comment 3 Jon Lee 2014-02-09 22:59:42 PST
Looks to me that we're running the path intersection algorithm as if the underline were under the character, rather than on the left hand side.
Comment 4 Jon Lee 2014-02-09 23:00:12 PST
I just restated what Yuki said ^_^
Comment 5 Myles C. Maxfield 2014-02-10 12:50:55 PST

*** This bug has been marked as a duplicate of bug 128145 ***
Comment 6 Myles C. Maxfield 2014-02-10 13:45:26 PST
Reopened: even if bug 128145 is fixed, text-orientation: upright will cause this bad behavior to be shown
Comment 7 Myles C. Maxfield 2014-02-12 19:29:39 PST
Stop-gap band-aid patch until a real fix can be made: https://bugs.webkit.org/show_bug.cgi?id=128718
Comment 8 David Kilzer (:ddkilzer) 2016-09-09 10:25:37 PDT
<rdar://problem/28227563>
Comment 9 rurumi663@gmail.com 2016-11-17 13:46:07 PST
Created attachment 295079 [details]
/Applications/Safari Technology Preview.app