Summary: | Subpixel rendering: Enable compositing RenderLayer painting on device pixel position. | ||
---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> |
Component: | Layout and Rendering | Assignee: | zalan <zalan> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, rniwa, simon.fraser |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 128694, 128911, 128913 | ||
Bug Blocks: | 129079 | ||
Attachments: |
Description
zalan
2014-02-09 18:03:28 PST
Created attachment 223662 [details]
patch
Comment on attachment 223662 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=223662&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2041 > + contentOrigin = IntPoint(m_contentsRect.location() - m_contentsClippingRect.location()); Is this always integral? > Source/WebCore/rendering/RenderLayerBacking.cpp:1228 > - IntSize offsetFromRenderer = m_graphicsLayer->offsetFromRenderer(); > + IntSize offsetFromRenderer = roundedIntSize(m_graphicsLayer->offsetFromRenderer()); Hm, not sure that this is right. (In reply to comment #2) > (From update of attachment 223662 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223662&action=review > > > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2041 > > + contentOrigin = IntPoint(m_contentsRect.location() - m_contentsClippingRect.location()); > > Is this always integral? > > > Source/WebCore/rendering/RenderLayerBacking.cpp:1228 > > - IntSize offsetFromRenderer = m_graphicsLayer->offsetFromRenderer(); > > + IntSize offsetFromRenderer = roundedIntSize(m_graphicsLayer->offsetFromRenderer()); > > Hm, not sure that this is right. No it's not right, but scrolling layers, overflowcontrols + alikes need another pass and at this point I am just sticking with the existing behavior for them (snapping to integral position). I should have mentioned it in the changelog entry. Created attachment 224588 [details]
Patch
for pre-review. (test cases and rebaselining is coming)
Created attachment 224655 [details]
Patch
Created attachment 224712 [details]
Patch
Comment on attachment 224712 [details] Patch Attachment 224712 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6356815939895296 New failing tests: fast/multicol/newmulticol/clipping.html Created attachment 224719 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 224712 [details] Patch Attachment 224712 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5365914639794176 New failing tests: fast/multicol/newmulticol/clipping.html Created attachment 224725 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 224712 [details] Patch Attachment 224712 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6427184684072960 New failing tests: fast/multicol/newmulticol/clipping.html Created attachment 224726 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 224712 [details] Patch Attachment 224712 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5796276536868864 New failing tests: fast/multicol/newmulticol/clipping.html Created attachment 224728 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
(In reply to comment #11) > (From update of attachment 224712 [details]) > Attachment 224712 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/6427184684072960 > > New failing tests: > fast/multicol/newmulticol/clipping.html oh, this one! I hoped it was just something wrong with my local env. :) (In reply to comment #15) > (In reply to comment #11) > > (From update of attachment 224712 [details] [details]) > > Attachment 224712 [details] [details] did not pass mac-wk2-ews (mac-wk2): > > Output: http://webkit-queues.appspot.com/results/6427184684072960 > > > > New failing tests: > > fast/multicol/newmulticol/clipping.html > > oh, this one! I hoped it was just something wrong with my local env. :) non-retina only. Created attachment 224783 [details]
Patch
Comment on attachment 224783 [details]
Patch
EWS testing.
Created attachment 224788 [details]
Patch
Comment on attachment 224788 [details]
Patch
EWS
Comment on attachment 224788 [details] Patch Clearing flags on attachment: 224788 Committed r164449: <http://trac.webkit.org/changeset/164449> All reviewed patches have been landed. Closing bug. Looks like this patch regressed fast/multicol/newmulticol/clipping.html ? e.g. http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r164471%20(16180)/results.html http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fmulticol%2Fnewmulticol%2Fclipping.html |