|Summary:||Web Inspector: element details hanger in inspector overlay should have better placement logic|
|Product:||WebKit||Reporter:||BJ Burg <bburg>|
|Component:||Web Inspector||Assignee:||Matt Baker <mattbaker>|
|Severity:||Normal||CC:||commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, madonnk, mattbaker, timothy, webkit-bug-importer|
|Version:||528+ (Nightly build)|
Description BJ Burg 2014-02-08 19:21:43 PST
The current implementation only places the hanger with the selected element's class name and dimensions to the right, and mangles the text by wrapping it if it's too far right. An example of this done correctly is the popovers used in the main web inspector UI.
Comment 2 Timothy Hatcher 2014-02-10 13:05:09 PST
Yeah, this bugs me. Especially for elements that have a near-zero width or height.
Comment 6 Matt Baker 2018-05-15 18:20:19 PDT
Created attachment 340460 [details] [HTML] Test Page This test includes eight boxes for testing element selection edge cases. Boxes 1-4 are aligned with the four corners of the view. Boxes 5-8 are aligned with the middle of each edge, but offset by their size to be completely outside the view. Hints are shown (each has an edge adjacent with the corresponding offscreen box).
Comment 7 Matt Baker 2018-05-15 18:20:59 PDT
This patch addresses tip positioning, but does not attempt to better position the arrow. That should be left as a follow-up.
Comment 8 WebKit Commit Bot 2018-05-15 22:30:14 PDT
Comment on attachment 340455 [details] Patch Clearing flags on attachment: 340455 Committed r231838: <https://trac.webkit.org/changeset/231838>
Comment 9 WebKit Commit Bot 2018-05-15 22:30:16 PDT
All reviewed patches have been landed. Closing bug.