Bug 128482

Summary: Web Inspector: element details hanger in inspector overlay should have better placement logic
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, madonnk, mattbaker, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Video] Before
none
[Video] After
none
[HTML] Test Page none

Blaze Burg
Reported 2014-02-08 19:21:43 PST
The current implementation only places the hanger with the selected element's class name and dimensions to the right, and mangles the text by wrapping it if it's too far right. An example of this done correctly is the popovers used in the main web inspector UI.
Attachments
Patch (2.92 KB, patch)
2018-05-15 18:08 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Video] Before (638.77 KB, video/mp4)
2018-05-15 18:17 PDT, Matt Baker 		no flags
Details
[Video] After (639.90 KB, video/mp4)
2018-05-15 18:17 PDT, Matt Baker 		no flags
Details
[HTML] Test Page (1.92 KB, text/html)
2018-05-15 18:20 PDT, Matt Baker 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-02-08 19:22:18 PST
<rdar://problem/16020709>
Timothy Hatcher
Comment 2 2014-02-10 13:05:09 PST
Yeah, this bugs me. Especially for elements that have a near-zero width or height.
Matt Baker
Comment 3 2018-05-15 18:08:28 PDT
Created attachment 340455 [details] Patch
Matt Baker
Comment 4 2018-05-15 18:17:23 PDT
Created attachment 340457 [details] [Video] Before
Matt Baker
Comment 5 2018-05-15 18:17:37 PDT
Created attachment 340458 [details] [Video] After
Matt Baker
Comment 6 2018-05-15 18:20:19 PDT
Created attachment 340460 [details] [HTML] Test Page This test includes eight boxes for testing element selection edge cases. Boxes 1-4 are aligned with the four corners of the view. Boxes 5-8 are aligned with the middle of each edge, but offset by their size to be completely outside the view. Hints are shown (each has an edge adjacent with the corresponding offscreen box).
Matt Baker
Comment 7 2018-05-15 18:20:59 PDT
This patch addresses tip positioning, but does not attempt to better position the arrow. That should be left as a follow-up.
WebKit Commit Bot
Comment 8 2018-05-15 22:30:14 PDT
Comment on attachment 340455 [details] Patch Clearing flags on attachment: 340455 Committed r231838: <https://trac.webkit.org/changeset/231838>
WebKit Commit Bot
Comment 9 2018-05-15 22:30:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.