Bug 128481

Summary: Cleanup the interface of FrameSelection
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, enrica, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 127832    
Attachments:
Description Flags
Cleanup
none
Patch for landing none

Description Ryosuke Niwa 2014-02-08 19:08:00 PST 
Rename some member functions and make others private.
Comment 1 Ryosuke Niwa 2014-02-08 19:13:39 PST 
Created attachment 223599 [details]
Cleanup
Comment 2 Ryosuke Niwa 2014-02-08 19:15:08 PST 
Comment on attachment 223599 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=223599&action=review

> Source/WebCore/ChangeLog:12
> +        Renamed caretRenderer() to caretRendererWithoutUpdatingLayout() to clarify the contract
> +        as the only caller of this function is RenderBlock::paintCaret.

I'm changing this sentence to:

        Renamed caretRenderer() to caretRendererWithoutUpdatingLayout() to clarify the contract
        as the only caller of this function is RenderBlock::paintCaret. Also renamed bounds()
        to selectionBounds() to make it more easily identifiable / grep'able.

when I land it.
Comment 3 Andreas Kling 2014-02-08 19:18:21 PST 
Comment on attachment 223599 [details]
Cleanup

Looks great. r=me
Comment 4 Ryosuke Niwa 2014-02-08 19:40:08 PST 
Created attachment 223600 [details]
Patch for landing
Comment 5 Ryosuke Niwa 2014-02-08 19:40:44 PST 
Comment on attachment 223600 [details]
Patch for landing

Wait for EWS.
Comment 6 WebKit Commit Bot 2014-02-08 20:53:15 PST 
Comment on attachment 223600 [details]
Patch for landing

Clearing flags on attachment: 223600

Committed r163739: <http://trac.webkit.org/changeset/163739>
Comment 7 WebKit Commit Bot 2014-02-08 20:53:17 PST 
All reviewed patches have been landed.  Closing bug.