Bug 128471

Summary: Switch the rest of CSS code from OwnPtr over to std::unique_ptr
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2014-02-08 13:38:17 PST 
Switch the rest of CSS code from OwnPtr over to std::unique_ptr
Comment 1 Zan Dobersek 2014-02-08 13:48:07 PST 
Created attachment 223583 [details]
Patch
Comment 2 WebKit Commit Bot 2014-02-08 13:50:08 PST 
Attachment 223583 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSParser.cpp:11607:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
ERROR: Source/WebCore/css/CSSParser.cpp:11639:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-02-08 17:43:53 PST 
Comment on attachment 223583 [details]
Patch

r=me
Comment 4 Zan Dobersek 2014-02-09 00:53:58 PST 
Comment on attachment 223583 [details]
Patch

Clearing flags on attachment: 223583

Committed r163747: <http://trac.webkit.org/changeset/163747>
Comment 5 Zan Dobersek 2014-02-09 00:54:04 PST 
All reviewed patches have been landed.  Closing bug.