Bug 128463

Summary: [GTK] Minibrowser: During text search, make navigation through list of matched words circular
Product: WebKit Reporter: Diego Pino <dpino>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Diego Pino 2014-02-08 11:46:04 PST 
Navigation through the list of matched search results using the 'Up' and 'Down' buttons doesn't work correctly. When the user reaches the last word, pressing the 'Down' button goes back to the search box and all highlighted words are unhighlighted. Pressing 'Down' again goes to the the first word although the matched words keep unhighlighted. 

The same happens in the opposite case, when reaching the first matched word and pressing 'Up'.

Steps to reproduce:

1. In Minibrowser, Press 'Ctrl+F' to open up the search box.
2. Keep pressing button 'Down' until reaching the last matched element.
3. Press 'Down' again.

Expected result: Navigation goes back to the first element. All the words keep highlighted.
Actual result: Navigation goes back to the search box, the search box background becomes red and all highlighted words are unhighlighted.
Comment 1 Diego Pino 2014-02-09 03:27:30 PST 
Created attachment 223625 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-02-10 03:36:11 PST 
Comment on attachment 223625 [details]
Patch

Thanks
Comment 3 WebKit Commit Bot 2014-02-10 03:37:27 PST 
Comment on attachment 223625 [details]
Patch

Rejecting attachment 223625 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 223625, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/6053250067333120
Comment 4 Diego Pino 2014-02-10 04:16:11 PST 
Created attachment 223693 [details]
Patch
Comment 5 WebKit Commit Bot 2014-02-10 04:57:36 PST 
Comment on attachment 223693 [details]
Patch

Clearing flags on attachment: 223693

Committed r163778: <http://trac.webkit.org/changeset/163778>
Comment 6 WebKit Commit Bot 2014-02-10 04:57:38 PST 
All reviewed patches have been landed.  Closing bug.