Bug 128437

Summary:

[ASan] Use new/delete in PODFreeListArena

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ayao, commit-queue, dfarler, ggaren, jeffrey+webkit, kling, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	none

Description David Kilzer (:ddkilzer) 2014-02-07 20:26:19 PST

The PODFreeListArena class doesn't actually deallocate objects when they're freed, so address sanitizer builds of WebKit won't catch use-after-free issues with objects that use it.

Comment 1 David Kilzer (:ddkilzer) 2014-02-07 20:45:48 PST

Created attachment 223542 [details]
Patch v1

Comment 2 WebKit Commit Bot 2014-02-07 21:28:10 PST

Comment on attachment 223542 [details]
Patch v1

Clearing flags on attachment: 223542

Committed r163693: <http://trac.webkit.org/changeset/163693>

Comment 3 WebKit Commit Bot 2014-02-07 21:28:12 PST

All reviewed patches have been landed.  Closing bug.