Bug 128434 – [GTK] [CMake] JavaScriptCore crashes in JSC::eval

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Martin Robinson]

Looks like we need to extend a fix from other ports.

[Martin Robinson]

Created attachment 223541 [details]
Patch

[Martin Robinson]

Zoltan, do you mind reviewing this one?

[Gyuyoung Kim]

Comment on attachment 223541 [details]
Patch

efl ews look like wrong alarm. rs=me.

[Martin Robinson]

Comment on attachment 223541 [details]
Patch

Landed in http://trac.webkit.org/changeset/164090 .

[Csaba Osztrogonác]

Comment on attachment 223541 [details]
Patch

EWS doesn't lie ... It broke the EFL build as the EWS noticed. I think the fno-maybe-uninitialized option was overwritten.

[Csaba Osztrogonác]

build log:
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Source/JavaScriptCore/runtime/JSArray.cpp: In member function ‘void JSC::JSArray::copyToArguments(JSC::ExecState*, JSC::CallFrame*, uint32_t)’:
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Source/JavaScriptCore/runtime/JSArray.cpp:1543:6: error: ‘value.JSC::JSValue::u.JSC::EncodedValueDescriptor::asInt64’ may be used uninitialized in this function [-Werror=uninitialized]
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Source/JavaScriptCore/runtime/JSArray.cpp:1543:6: error: ‘value.JSC::JSValue::u.JSC::EncodedValueDescriptor::asInt64’ may be used uninitialized in this function [-Werror=uninitialized]
cc1plus: all warnings being treated as errors

The problem was caused by the -fno-tree-dce option. Unfortunately this error
message isn't so useful because of inline functions. (line 1543 is the first
line of the copyToArguments() function)

I played a little bit with this function and it seems the problem is near here:
https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/JSArray.cpp#L1598

With commenting out this line, build works, so the build failure occured
in this line. But unfortunately I have no idea how can it be uninitialized.

[Martin Robinson]

Created attachment 224319 [details]
Patch

[Martin Robinson]

Okay. I reworked the patch to only apply to the GTK+ port. Thanks for the cleanup Ossy.

[Martin Robinson]

Okay. I reworked the patch to only apply to the GTK+ port. Thanks for the cleanup Ossy.

[Csaba Osztrogonác]

Comment on attachment 224319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224319&action=review

> ChangeLog:9
> +        * Source/cmake/OptionsGTK.cmake: Add -fno-omit-frame-pointer to all ports as well
> +        as -fno-tree-dce, like it is used in the autotools build.

-fno-tree-dce is GTK only now, please fix the comment before landing.

[Martin Robinson]

Committed r164257: <http://trac.webkit.org/changeset/164257>