Summary: | Crash on ARM due to mis-alignment | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oscar Cwajbaum <public> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | kkowalczyk | ||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Other | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Oscar Cwajbaum
2007-02-21 04:29:36 PST
Created attachment 13292 [details]
Fix ARM crash due to mis-alignment
Comment on attachment 13292 [details]
Fix ARM crash due to mis-alignment
I think there's a more-portable way to solve this problem. We could make pageheap_memory be an array of pointers instead of an array of char. That would ive us the alignment we need to store pointers in it.
static void* pageheap_memory[(sizeof(TCMalloc_PageHeap) + sizeof(void*) - 1) / sizeof(void*)];
What do you think?
I agree with Darin. I think it is better to enforce the alignment in a portable way, by making the array be a pointer array or the like. Created attachment 13312 [details]
Fix ARM crash due to mis-alignment - rev2
Sounds good to me. I've attached a modified patch with Darin's suggestion. Comment on attachment 13312 [details]
Fix ARM crash due to mis-alignment - rev2
r=me
|