| Summary: | AX: Add text replacement activity support to NSAccessibilitySelectTextWithCriteriaParameterizedAttribute. | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Samuel White <samuel_white> | ||||||||||||||||||||||
| Component: | Accessibility | Assignee: | Samuel White <samuel_white> | ||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, rniwa, webkit-bug-importer | ||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||
| Hardware: | Mac (Intel) | ||||||||||||||||||||||||
| OS: | OS X 10.9 | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Samuel White
2014-02-07 14:12:40 PST
Created attachment 223745 [details]
Patch.
Created attachment 223750 [details]
Updated patch.
Fixing small bit of faulty logic.
Created attachment 223753 [details]
Updated patch to fix build issues.
Comment on attachment 223753 [details] Updated patch to fix build issues. Attachment 223753 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5947622191792128 New failing tests: editing/unsupported-content/list-type-before.html editing/unsupported-content/table-type-before.html editing/unsupported-content/list-delete-001.html platform/mac/accessibility/select-text.html editing/unsupported-content/list-type-after.html editing/unsupported-content/table-type-after.html Created attachment 223760 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 223764 [details]
More build fixing.
Created attachment 223771 [details]
Updated patch to fix more build issues.
Comment on attachment 223771 [details] Updated patch to fix more build issues. Attachment 223771 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6744245880750080 New failing tests: platform/mac/accessibility/select-text.html Created attachment 223791 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 223771 [details] Updated patch to fix more build issues. Attachment 223771 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6259113621192704 New failing tests: platform/mac/accessibility/select-text.html Created attachment 223793 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 223771 [details] Updated patch to fix more build issues. Attachment 223771 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5015626099720192 New failing tests: platform/mac/accessibility/select-text.html Created attachment 223801 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 223807 [details]
Fixed patch.
Comment on attachment 223807 [details]
Fixed patch.
Fixed up the build issues. Should be good to go.
Comment on attachment 223807 [details] Fixed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=223807&action=review > Source/WebCore/accessibility/AccessibilityObject.h:406 > + AccessibilitySelectTextCriteria(AccessibilitySelectTextActivity activity, AccessibilitySelectTextAmbiguityResolution ambiguityResolution, String replacementString) I think this can be const String&, since we're going to copy it anyway with , replacementString(replacementString) > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:637 > + if ([activityParameter isEqualToString:NSAccessibilitySelectTextActivityFindAndReplace]) you can probably put this if statement together with the one above (In reply to comment #17) > (From update of attachment 223807 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223807&action=review > > > Source/WebCore/accessibility/AccessibilityObject.h:406 > > + AccessibilitySelectTextCriteria(AccessibilitySelectTextActivity activity, AccessibilitySelectTextAmbiguityResolution ambiguityResolution, String replacementString) > > I think this can be const String&, since we're going to copy it anyway with , replacementString(replacementString) Seems like a good optimization to me. > > > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:637 > > + if ([activityParameter isEqualToString:NSAccessibilitySelectTextActivityFindAndReplace]) > > you can probably put this if statement together with the one above They are separate because each new activity will be a new if statement. See the other parameter handling around it. I'll add the above optimization and commit directly. Thanks! Patch landed: http://trac.webkit.org/changeset/163899 Closing bug. |