Bug 128384

Summary:

[iOS] Eliminate race between XPC connection queue and Notification queue

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ddkilzer, ggaren, joepeck, timothy

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2014-02-07 11:12:08 PST

Radar: <rdar://problem/16009483> * STEPS TO REPRODUCE 1. Launch Remote Debugger 2. Launch MobileSafari 3. Suspend MobileSafari 4. Close Remote Debugger 5. Launch Remote Debugger 6. Launch MobileSafari => at either step (5) or (6) the suspended -> resumed MobileSafari should have responded to the "com.apple.webinspectord.available" notification and re-connected to webinspectord. However, it did not. This is a race between the notification handler on a generic global queue and the xpc failed notification being handled on the XPC connection queue. Sharing a queue gives us the correct deterministic ordering.

Attachments
[PATCH] Proposed Fix (5.46 KB, patch) 2014-02-07 11:14 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2014-02-07 11:14:21 PST

Created attachment 223475 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 2 2014-02-07 14:26:05 PST

Comment on attachment 223475 [details] [PATCH] Proposed Fix Clearing flags on attachment: 223475 Committed r163648: <http://trac.webkit.org/changeset/163648>

WebKit Commit Bot

Comment 3 2014-02-07 14:26:07 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.