Bug 128376 – [GTK] build-webkit script always generate-gtk-doc even if '--disable-gtk-doc' param is passed

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Diego Pino]

How to reproduce:

* Execute script Tools/Script/build-webkit --disable-gtk-doc.

Expected result: The script Tools/gtk/generate-gtkdoc should not be called.
Actual result: The script Tools/gtk/generate-gtkdoc is called.

[Diego Pino]

Created attachment 223457 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 223457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223457&action=review

> Tools/Scripts/webkitdirs.pm:1858
> +    my $disableGTKDoc = grep /^--disable-gtk-doc$/, @buildArgs;

Would it be possible to use checkForArgumentAndRemoveFromARGV() here?

[Martin Robinson]

This is by design. Probably we just want to disable it temporarily until the bots are fixed.

[Diego Pino]

Created attachment 223463 [details]
Patch

[Carlos Garcia Campos]

(In reply to comment #3)
> This is by design. Probably we just want to disable it temporarily until the bots are fixed.

I think we should respect the option. I'm fine with the bots not passing that option, but if I run build-webkit --disable-gtk-doc I don't want the doc to be generated.

[Diego Pino]

Actually I had this bug in my local repo. Although I run build-webkit with "--disable-gtk-doc", the script tried to generate the GTK near the end of and the compilation failed. To solve that issued, I had a temporal fix that disabled GTK doc generation in Tools/gtk/generate-gtkdoc.

[WebKit Commit Bot]

Comment on attachment 223463 [details]
Patch

Clearing flags on attachment: 223463

Committed r163697: <http://trac.webkit.org/changeset/163697>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.