Summary: | [GTK] build-webkit script always generate-gtk-doc even if '--disable-gtk-doc' param is passed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Diego Pino <dpino> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Minor | CC: | cgarcia, commit-queue, dbates, gustavo, mrobinson, zan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Diego Pino
2014-02-07 08:30:33 PST
Created attachment 223457 [details]
Patch
Comment on attachment 223457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223457&action=review > Tools/Scripts/webkitdirs.pm:1858 > + my $disableGTKDoc = grep /^--disable-gtk-doc$/, @buildArgs; Would it be possible to use checkForArgumentAndRemoveFromARGV() here? This is by design. Probably we just want to disable it temporarily until the bots are fixed. Created attachment 223463 [details]
Patch
(In reply to comment #3) > This is by design. Probably we just want to disable it temporarily until the bots are fixed. I think we should respect the option. I'm fine with the bots not passing that option, but if I run build-webkit --disable-gtk-doc I don't want the doc to be generated. Actually I had this bug in my local repo. Although I run build-webkit with "--disable-gtk-doc", the script tried to generate the GTK near the end of and the compilation failed. To solve that issued, I had a temporal fix that disabled GTK doc generation in Tools/gtk/generate-gtkdoc. Comment on attachment 223463 [details] Patch Clearing flags on attachment: 223463 Committed r163697: <http://trac.webkit.org/changeset/163697> All reviewed patches have been landed. Closing bug. |