Bug 128376

Summary: [GTK] build-webkit script always generate-gtk-doc even if '--disable-gtk-doc' param is passed
Product: WebKit Reporter: Diego Pino <dpino>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Severity: Minor CC: cgarcia, commit-queue, dbates, gustavo, mrobinson, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Diego Pino 2014-02-07 08:30:33 PST
How to reproduce:

* Execute script Tools/Script/build-webkit --disable-gtk-doc.

Expected result: The script Tools/gtk/generate-gtkdoc should not be called.
Actual result: The script Tools/gtk/generate-gtkdoc is called.
Comment 1 Diego Pino 2014-02-07 08:34:31 PST
Created attachment 223457 [details]
Comment 2 Carlos Garcia Campos 2014-02-07 09:18:30 PST
Comment on attachment 223457 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=223457&action=review

> Tools/Scripts/webkitdirs.pm:1858
> +    my $disableGTKDoc = grep /^--disable-gtk-doc$/, @buildArgs;

Would it be possible to use checkForArgumentAndRemoveFromARGV() here?
Comment 3 Martin Robinson 2014-02-07 09:40:39 PST
This is by design. Probably we just want to disable it temporarily until the bots are fixed.
Comment 4 Diego Pino 2014-02-07 10:11:42 PST
Created attachment 223463 [details]
Comment 5 Carlos Garcia Campos 2014-02-07 10:15:00 PST
(In reply to comment #3)
> This is by design. Probably we just want to disable it temporarily until the bots are fixed.

I think we should respect the option. I'm fine with the bots not passing that option, but if I run build-webkit --disable-gtk-doc I don't want the doc to be generated.
Comment 6 Diego Pino 2014-02-07 10:43:28 PST
Actually I had this bug in my local repo. Although I run build-webkit with "--disable-gtk-doc", the script tried to generate the GTK near the end of and the compilation failed. To solve that issued, I had a temporal fix that disabled GTK doc generation in Tools/gtk/generate-gtkdoc.
Comment 7 WebKit Commit Bot 2014-02-08 00:19:16 PST
Comment on attachment 223463 [details]

Clearing flags on attachment: 223463

Committed r163697: <http://trac.webkit.org/changeset/163697>
Comment 8 WebKit Commit Bot 2014-02-08 00:19:19 PST
All reviewed patches have been landed.  Closing bug.