Summary: | IDB: Remove the entirely unnecessary "Value Key" concept | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alecflett, commit-queue, jsbell, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Brady Eidson
2014-02-06 21:12:47 PST
Created attachment 223420 [details]
Patch v1
Attachment 223420 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:154: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:43: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:66: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 3 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 223421 [details]
Patch v2 - Changelog comment for one method that has non-mechanical changes.
Attachment 223421 [details] did not pass style-queue:
ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:154: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:43: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:66: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 3 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 223421 [details] Patch v2 - Changelog comment for one method that has non-mechanical changes. View in context: https://bugs.webkit.org/attachment.cgi?id=223421&action=review > Source/WebCore/ChangeLog:10 > + All cursor operations were setup to pass a value key parameter around, but it was: setup -> set up |