Bug 128360

Summary: IDB: Remove the entirely unnecessary "Value Key" concept
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, commit-queue, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1
none
Patch v2 - Changelog comment for one method that has non-mechanical changes. mitz: review+

Description Brady Eidson 2014-02-06 21:12:47 PST
IDB: Remove the entirely unnecessary "Value Key" concept

Turns out this and the primary key are the same thing.
Comment 1 Radar WebKit Bug Importer 2014-02-06 21:13:15 PST
<rdar://problem/16009422>
Comment 2 Brady Eidson 2014-02-06 21:42:59 PST
Created attachment 223420 [details]
Patch v1
Comment 3 WebKit Commit Bot 2014-02-06 21:44:10 PST
Attachment 223420 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:154:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:43:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:66:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brady Eidson 2014-02-06 21:45:54 PST
Created attachment 223421 [details]
Patch v2 - Changelog comment for one method that has non-mechanical changes.
Comment 5 WebKit Commit Bot 2014-02-06 21:46:42 PST
Attachment 223421 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:154:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:43:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:66:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 mitz 2014-02-06 21:51:46 PST
Comment on attachment 223421 [details]
Patch v2 - Changelog comment for one method that has non-mechanical changes.

View in context: https://bugs.webkit.org/attachment.cgi?id=223421&action=review

> Source/WebCore/ChangeLog:10
> +        All cursor operations were setup to pass a value key parameter around, but it was:

setup -> set up
Comment 7 Brady Eidson 2014-02-06 22:33:47 PST
http://trac.webkit.org/changeset/163612
Comment 8 Brady Eidson 2014-02-06 23:20:14 PST
and http://trac.webkit.org/changeset/163613