Bug 128360

Summary: IDB: Remove the entirely unnecessary "Value Key" concept
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, commit-queue, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1
none
Patch v2 - Changelog comment for one method that has non-mechanical changes. mitz: review+

Brady Eidson
Reported 2014-02-06 21:12:47 PST
IDB: Remove the entirely unnecessary "Value Key" concept Turns out this and the primary key are the same thing.
Attachments
Patch v1 (76.86 KB, patch)
2014-02-06 21:42 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v2 - Changelog comment for one method that has non-mechanical changes. (76.98 KB, patch)
2014-02-06 21:45 PST, Brady Eidson 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-02-06 21:13:15 PST
<rdar://problem/16009422>
Brady Eidson
Comment 2 2014-02-06 21:42:59 PST
Created attachment 223420 [details] Patch v1
WebKit Commit Bot
Comment 3 2014-02-06 21:44:10 PST
Attachment 223420 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:43: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:66: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 4 2014-02-06 21:45:54 PST
Created attachment 223421 [details] Patch v2 - Changelog comment for one method that has non-mechanical changes.
WebKit Commit Bot
Comment 5 2014-02-06 21:46:42 PST
Attachment 223421 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:154: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:43: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:66: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 6 2014-02-06 21:51:46 PST
Comment on attachment 223421 [details] Patch v2 - Changelog comment for one method that has non-mechanical changes. View in context: https://bugs.webkit.org/attachment.cgi?id=223421&action=review > Source/WebCore/ChangeLog:10 > + All cursor operations were setup to pass a value key parameter around, but it was: setup -> set up
Brady Eidson
Comment 7 2014-02-06 22:33:47 PST
http://trac.webkit.org/changeset/163612
Brady Eidson
Comment 8 2014-02-06 23:20:14 PST
and http://trac.webkit.org/changeset/163613
Note You need to log in before you can comment on or make changes to this bug.