| Summary: | [Win] Enable JSC stress tests by default | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||||
| Component: | Tools / Tests | Assignee: | Csaba Osztrogonác <ossy> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, bfulgham, commit-queue, fpizlo, ossy, peavo, roger_fong, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 140846, 120809 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Csaba Osztrogonác
2014-02-06 08:50:37 PST
Peavo mentioned that stress tests work on Apple Windows port, except 18 failures: https://bugs.webkit.org/show_bug.cgi?id=136950#c8 Could you send the list of the failures here? I assume they are the same as skipped in mozilla jsc tests for Windows only. We can skip them properly and then enable jsc stress tests on Windows bots. Here are the failures for Win32:
** The following JSC stress test failures have been introduced:
jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout
jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-dfg-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-cjit
jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-llint
mozilla-tests.yaml/ecma/Date/15.9.5.31-1.js.mozilla
mozilla-tests.yaml/ecma/Date/15.9.5.31-1.js.mozilla-baseline
mozilla-tests.yaml/ecma/Date/15.9.5.31-1.js.mozilla-dfg-eager-no-cjit-validate-phases
mozilla-tests.yaml/ecma/Date/15.9.5.31-1.js.mozilla-llint
mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla
mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-baseline
mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-dfg-eager-no-cjit-validate-phases
mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-llint
stress/ftl-arithcos.js.always-trigger-copy-phase
stress/ftl-arithcos.js.default
stress/ftl-arithcos.js.dfg-eager
stress/ftl-arithcos.js.dfg-eager-no-cjit-validate
stress/ftl-arithcos.js.no-cjit-validate-phases
stress/ftl-arithcos.js.no-llint
Results for JSC stress tests:
18 failures found.
Created attachment 245223 [details]
Patch
Comment on attachment 245223 [details]
Patch
cq-, because I can't test it on Windows. It would
be great if somebody could test it before landing.
Comment on attachment 245223 [details]
Patch
These changes look good to me. I'll attempt to run them locally once I land a change I'm working on.
This patch may be fine, but for some reason I cannot run the JSC stress tests: Log: PASS: returned private data when set by JSObjectSetPrivate(). PASS: returned null when accessing character pointer of a null String. PASS: returned empty when accessing character pointer of an empty String. PASS: returned 0 length for null String. PASS: returned 0 length for empty String. [ .... etc. ... ] PASS: A cycle in a prototype chain can't be created. PASS: throwException did not crash when handling an error with appendMessageToError set and no codeBlock available. PASS: global context name behaves as expected. PASS: Program exited normally. testAPI completed with rc=0 (0) Running: /usr/bin/env ruby Tools/Scripts/run-jsc-stress-tests -j /cygdrive/c/Projects/WebKit/OpenSource/WebKitBuild/Release/bin32/jsc.exe -o /cygdrive/c/Projects/WebKit/OpenSource/WebKitBuild/Release/bin32/jsc-stress-results PerformanceTests/SunSpider/tests/sunspider-1.0 Source/JavaScriptCore/tests/exceptionFuzz.yaml PerformanceTests/SunSpider/no-architecture-specific-optimizations.yaml PerformanceTests/SunSpider/tests/v8-v6 Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml Source/JavaScriptCore/tests/stress LayoutTests/js/regress/script-tests PerformanceTests/SunSpider/profiler-test.yaml LayoutTests/jsc-layout-tests.yaml Source/JavaScriptCore/tests/typeProfiler.yaml --ftl-jit -- /cygdrive/c/Projects/WebKit/Internal/Tools/Scripts/../../Tests/InternalJSTests/internal-js-tests.yaml Warning: unable to execute otool. Warning: unable to determine architecture. Warning: cannot identify JSC framework, doing generic VM copy. Tools/Scripts/run-jsc-stress-tests:1009:in `eval': (eval):3: syntax error, unexpected keyword_else, expecting ')' (SyntaxError) (eval):5: syntax error, unexpected keyword_end, expecting ')' from Tools/Scripts/run-jsc-stress-tests:1009:in `block (3 levels) in handleCollectionFile' from Tools/Scripts/run-jsc-stress-tests:1002:in `each' from Tools/Scripts/run-jsc-stress-tests:1002:in `block (2 levels) in handleCollectionFile' from Tools/Scripts/run-jsc-stress-tests:997:in `chdir' from Tools/Scripts/run-jsc-stress-tests:997:in `block in handleCollectionFile' from Tools/Scripts/run-jsc-stress-tests:963:in `each' from Tools/Scripts/run-jsc-stress-tests:963:in `handleCollectionFile' from Tools/Scripts/run-jsc-stress-tests:1044:in `handleCollection' from Tools/Scripts/run-jsc-stress-tests:1109:in `block in prepareBundle' from Tools/Scripts/run-jsc-stress-tests:1107:in `each' from Tools/Scripts/run-jsc-stress-tests:1107:in `prepareBundle' from Tools/Scripts/run-jsc-stress-tests:1444:in `runNormal' from Tools/Scripts/run-jsc-stress-tests:1476:in `<main>' Looks good to me, but shouldn't there be a ')' character at the end of line 352 and 1541 in mozilla-tests.yaml? 351 cmd: | 352 if ($hostOS == "windows" 353 skip 1540 cmd: | 1541 if ($hostOS == "windows" 1542 skip Latest stress test results from WinCairo 32-bit:
** The following JSC stress test failures have been introduced:
jsc-layout-tests.yaml/js/script-tests/date-constructor.js.layout
jsc-layout-tests.yaml/js/script-tests/date-constructor.js.layout-dfg-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/date-constructor.js.layout-no-cjit
jsc-layout-tests.yaml/js/script-tests/date-constructor.js.layout-no-llint
jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout
jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-dfg-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-cjit
jsc-layout-tests.yaml/js/script-tests/sort-stability.js.layout-no-llint
mozilla-tests.yaml/ecma/Date/15.9.5.31-1.js.mozilla
mozilla-tests.yaml/ecma/Date/15.9.5.31-1.js.mozilla-baseline
mozilla-tests.yaml/ecma/Date/15.9.5.31-1.js.mozilla-dfg-eager-no-cjit-validate-phases
mozilla-tests.yaml/ecma/Date/15.9.5.31-1.js.mozilla-llint
mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla
mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-baseline
mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-dfg-eager-no-cjit-validate-phases
mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-llint
stress/ftl-arithcos.js.always-trigger-copy-phase
stress/ftl-arithcos.js.default
stress/ftl-arithcos.js.dfg-eager
stress/ftl-arithcos.js.dfg-eager-no-cjit-validate
stress/ftl-arithcos.js.no-cjit-validate-phases
stress/ftl-arithcos.js.no-llint
Results for JSC stress tests:
22 failures found.
Created attachment 245301 [details]
Patch
typo fixed in mozilla-tests.yaml
Created attachment 245302 [details]
Patch
skipped date-constructor.js too
This patch works properly. Comment on attachment 245302 [details]
Patch
r=me.
Comment on attachment 245302 [details] Patch Clearing flags on attachment: 245302 Committed r179165: <http://trac.webkit.org/changeset/179165> All reviewed patches have been landed. Closing bug. This caused 6 JSC test failures on Mac. Comment on attachment 245302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245302&action=review > Source/JavaScriptCore/tests/mozilla/mozilla-tests.yaml:-1535 > - cmd: defaultRunMozillaTest :normal, "../shell.js", "shell.js" Must be losing "shell.js" here. oops, fixed in http://trac.webkit.org/changeset/179169 |