Bug 128234

Summary:

Make FTL OSR entry something we only try after we've already compiled the function with the FTL and it still got stuck in a loop after that without ever returning like a sensible function oughta have

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

atrick, barraclough, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

128039

Attachments:

Description	Flags
work in progress	none
the patch	ggaren: review+

Description Filip Pizlo 2014-02-04 21:44:29 PST

Patch forthcoming.

This appears to still give us a speed-up on the kinds of things that OSR entry is good for, while also eliminating pointless OSR entry compilations on other things.

Comment 1 Filip Pizlo 2014-02-04 21:55:25 PST

Created attachment 223211 [details]
work in progress

Still needs testing.  The approach still feels shady.

Comment 2 Filip Pizlo 2014-02-05 22:27:01 PST

Created attachment 223309 [details]
the patch

Comment 3 Geoffrey Garen 2014-02-05 22:30:39 PST

Comment on attachment 223309 [details]
the patch

r=me

Comment 4 Filip Pizlo 2014-02-05 23:32:41 PST

Landed in http://trac.webkit.org/changeset/163517