Summary: | The stack limit computation does not work for Windows | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, bfulgham, cmarcelo, commit-queue, fpizlo, ggaren, mhahnenberg, msaboff, oliver, roger_fong | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 127940 | ||||||||||
Attachments: |
|
Description
Mark Lam
2014-02-04 18:16:14 PST
Created attachment 223195 [details]
fixed StackBound::recursionLimit() to handle underflows.
Comment on attachment 223195 [details] fixed StackBound::recursionLimit() to handle underflows. View in context: https://bugs.webkit.org/attachment.cgi?id=223195&action=review > Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:156 > + CLoopRegister() { i = static_cast<intptr_t>(0xbadbeef0baddbeef); } tasty, but won't this break in 32bit builds? Comment on attachment 223195 [details] fixed StackBound::recursionLimit() to handle underflows. View in context: https://bugs.webkit.org/attachment.cgi?id=223195&action=review >> Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:156 >> + CLoopRegister() { i = static_cast<intptr_t>(0xbadbeef0baddbeef); } > > tasty, but won't this break in 32bit builds? Nope. That's what the static_cast<intptr_t> takes care of for me. I verified that the 32-bit build is happy. Created attachment 223198 [details]
I fixed the patch, but apparently uploaded the wrong one. Round 2.
Comment on attachment 223198 [details]
I fixed the patch, but apparently uploaded the wrong one. Round 2.
A bad patch again. Redoing.
Created attachment 223200 [details]
Trying again.
Patch 3 has passed the layout tests with a debug build. Comment on attachment 223200 [details]
Trying again.
r=me
Comment on attachment 223200 [details] Trying again. Clearing flags on attachment: 223200 Committed r163428: <http://trac.webkit.org/changeset/163428> All reviewed patches have been landed. Closing bug. |