Bug 128222

Summary:

Reduce boilerplate in BlockAllocator.h

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	fpizlo: review+

Description Mark Hahnenberg 2014-02-04 16:07:19 PST

There are a lot of template specializations for the various types of HeapBlocks in BlockAllocator.h. We could reduce the spew by using a macro.

Comment 1 Mark Hahnenberg 2014-02-04 16:11:09 PST

Created attachment 223179 [details]
Patch

Comment 2 Filip Pizlo 2014-02-04 17:15:28 PST

Comment on attachment 223179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223179&action=review

> Source/JavaScriptCore/heap/BlockAllocator.h:238
> +REGION_SET_FOR(HandleBlock, m_fourKBBlockRegionSet);
>  

Maybe can you #undef REGION_SET_FOR here?

Comment 3 Mark Hahnenberg 2014-02-04 17:23:22 PST

Committed r163419: <http://trac.webkit.org/changeset/163419>