Bug 128222

Summary: Reduce boilerplate in BlockAllocator.h
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Mark Hahnenberg
Reported 2014-02-04 16:07:19 PST
There are a lot of template specializations for the various types of HeapBlocks in BlockAllocator.h. We could reduce the spew by using a macro.
Attachments
Patch (3.50 KB, patch)
2014-02-04 16:11 PST, Mark Hahnenberg 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-02-04 16:11:09 PST
Created attachment 223179 [details] Patch
Filip Pizlo
Comment 2 2014-02-04 17:15:28 PST
Comment on attachment 223179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223179&action=review > Source/JavaScriptCore/heap/BlockAllocator.h:238 > +REGION_SET_FOR(HandleBlock, m_fourKBBlockRegionSet); > Maybe can you #undef REGION_SET_FOR here?
Mark Hahnenberg
Comment 3 2014-02-04 17:23:22 PST
Committed r163419: <http://trac.webkit.org/changeset/163419>
Note You need to log in before you can comment on or make changes to this bug.