Bug 128213

Summary: Remove <iframe seamless> support.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, allan.jensen, apinheiro, benjamin, buildbot, bunhere, cdumez, cfleizach, cmarcelo, commit-queue, dbates, dmazzoni, esprehn+autocc, glenn, gyuyoung.kim, japhet, jcraig, jdiggs, kangil.han, kling, kondapallykalyan, macpherson, mario, menard, rakuco, rniwa, samuel_white, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Patch none

Description Andreas Kling 2014-02-04 15:11:58 PST
Remove <iframe seamless> support.
Comment 1 Andreas Kling 2014-02-04 15:12:22 PST
Seamless iframes were behind a runtime flag that we never enabled, and the only other engine that implemented them (Blink) recently removed them. Since the feature is very invasive, let's take it out for now.
Comment 2 Andreas Kling 2014-02-04 16:36:00 PST
Created attachment 223180 [details]
Patch
Comment 3 WebKit Commit Bot 2014-02-04 16:38:41 PST
Attachment 223180 [details] did not pass style-queue:


ERROR: ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andreas Kling 2014-02-04 17:01:33 PST
Created attachment 223181 [details]
Patch
Comment 5 Andreas Kling 2014-02-04 17:06:56 PST
Created attachment 223182 [details]
Patch
Comment 6 Andreas Kling 2014-02-04 17:40:28 PST
Created attachment 223189 [details]
Patch
Comment 7 Build Bot 2014-02-04 19:13:51 PST
Comment on attachment 223189 [details]
Patch

Attachment 223189 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6745889108393984

New failing tests:
platform/mac/accessibility/seamless-iframe.html
Comment 8 Build Bot 2014-02-04 19:13:57 PST
Created attachment 223197 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 Andreas Kling 2014-02-04 20:07:07 PST
Created attachment 223204 [details]
Patch
Comment 10 WebKit Commit Bot 2014-02-04 20:54:37 PST
Comment on attachment 223204 [details]
Patch

Clearing flags on attachment: 223204

Committed r163427: <http://trac.webkit.org/changeset/163427>
Comment 11 WebKit Commit Bot 2014-02-04 20:54:41 PST
All reviewed patches have been landed.  Closing bug.