Bug 128190

Summary:

[CSS Shapes] Add initial performance test for shape-outside: content-box

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

Tools / Tests

Assignee:

Zoltan Horvath <zoltan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

128188

Attachments:

Description	Flags
Patch	rniwa: review+
Patch for landing	none

Description Zoltan Horvath 2014-02-04 09:40:35 PST

I've introduced Shapes subdirectory in Layout, every CSS Shapes related performance tests should go here in the future.
The initial performance tests uses 'shape-outside: content-box' in order to tests the code paths of the Shapes implementation. I also introduced shapes.js, which allows us to easily add new, simple performance tests for shape-outside. 
The entire progress is tracked under #128188 meta bug.

Comment 1 Zoltan Horvath 2014-02-04 09:43:59 PST

Created attachment 223127 [details]
Patch

Comment 2 Ryosuke Niwa 2014-02-04 13:04:17 PST

Comment on attachment 223127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223127&action=review

> PerformanceTests/ChangeLog:15
> +        * Layout/Shapes/ShapeOutsideContentBox.html: Added.

Please skip the test by default in Skipped for now since this looks like a micro benchmark.

> PerformanceTests/Layout/Shapes/ShapeOutsideContentBox.html:6
> +        <script src="resources/shapes.js"></script>

We should include the script in this file instead for now and extract the shared code into js as needed.

Comment 3 Zoltan Horvath 2014-02-04 19:30:32 PST

Created attachment 223199 [details]
Patch for landing

(In reply to comment #2)
> (From update of attachment 223127 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223127&action=review
> 
> > PerformanceTests/ChangeLog:15
> > +        * Layout/Shapes/ShapeOutsideContentBox.html: Added.
> 
> Please skip the test by default in Skipped for now since this looks like a micro benchmark.

I skipped the test.

> > PerformanceTests/Layout/Shapes/ShapeOutsideContentBox.html:6
> > +        <script src="resources/shapes.js"></script>
> 
> We should include the script in this file instead for now and extract the shared code into js as needed.

Okay. I moved into the html for now.

Comment 4 WebKit Commit Bot 2014-02-04 20:05:54 PST

Comment on attachment 223199 [details]
Patch for landing

Clearing flags on attachment: 223199

Committed r163424: <http://trac.webkit.org/changeset/163424>

Comment 5 WebKit Commit Bot 2014-02-04 20:05:58 PST

All reviewed patches have been landed.  Closing bug.