Bug 128172 – [Tests] some tests in fast/events/touch test non-replicable platform-specific behavior

• Component: Tools / Tests
• Status: NEW

[Carlos Garnacho]

In the workings of a patch for bug #98931 to add touch support for GTK+, multiple tests had to be skipped because they tested platform-specific behavior in several ways:
- The EventSenderProxy object is expected to coalesce multiple operations under one single event. Under X11/GTK+, each touch update will emit an independent event that can't be coalesced, as there is nothing that groups touch IDs at that layer, so that brings 1) a different number of events than many tests expect and 2) different expectations if the effect of two touch updates are expected to happen at once.
- On some other tests, touch IDs were directly tested, even though platforms may generate those differently, as it happens with X11

So in order to be useful more generally I'd propose to change those tests to test the coherence of the events gotten, rather than a fixed stream of those. The events currently tested would be rather considered "milestones", and intermediate events that still maintain coherence would be safely skipped, that way those tests would also be useful to test GTK+ behavior. As for touch IDs, comparing those from previous events is fine, checking fixed numbers is not...

[Carlos Alberto Lopez Perez]

The test fast/events/touch/touch-target-limited.html crashes on wk2-gtk.

Program terminated with signal 11, Segmentation fault.
#0  gdk_event_free (event=0x4f73bd2b) at gdkevents.c:654
654	  if (event->any.window)


Thread 1 (Thread 0x7f318f79ca00 (LWP 17147)):
#0  gdk_event_free (event=0x4f73bd2b) at gdkevents.c:654
#1  0x00007f319dcfb042 in WebCore::GtkTouchContextHelper::handleEvent(_GdkEvent*) () from /stuff/webkit/webkit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
#2  0x00007f319c7eaece in webkitWebViewBaseTouchEvent(_GtkWidget*, _GdkEventTouch*) () from /stuff/webkit/webkit/WebKitBuild/Release/.libs/libwebkit2gtk-3.0.so.25
[....]


I'm attaching the full crashlog

[Carlos Alberto Lopez Perez]

Created attachment 227079 [details]
gdb backtrace for crash on test fast/events/touch/touch-target-limited.html on wk2 gtk (r165814)

[Carlos Alberto Lopez Perez]

Created attachment 227101 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 227101 [details]
Patch

Ups. I messed up with the webkit-patch upload script. This is a gardening patch. I just created a new bug for it #130421

Sorry for the noise.

[Alicia Boya García]

fast/events/touch/touch-target.html has started crashing too on GTK since r225977-225987.

[Miguel Gomez]

fast/events/touch/basic-single-touch-events.html

besides fail and crash it can also timeout now.