Bug 128169

Summary: [SOUP] Remove custom URI schemes implementation
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, gyuyoung.kim, p.jacquemart, rakuco, ryuan.choi, sergio
Priority: P2 Keywords: Soup
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 128177    
Bug Blocks:    
Attachments:
Description Flags
Checking if we can fully remove this CUSTOM_PROTOCOLS flag
none
Remove custom URI schemes implementation none

Carlos Garcia Campos
Reported 2014-02-04 02:27:35 PST
In favor of using custom protocols. All ports based on soup should switch to custom protocols, now that there's a soup implementation.
Attachments
Checking if we can fully remove this CUSTOM_PROTOCOLS flag (63.90 KB, patch)
2014-10-09 09:37 PDT, Pascal Jacquemart 		no flags
DetailsFormatted DiffDiff
Remove custom URI schemes implementation (35.08 KB, patch)
2014-10-10 03:19 PDT, Pascal Jacquemart 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pascal Jacquemart
Comment 1 2014-10-09 09:37:38 PDT
Created attachment 239544 [details] Checking if we can fully remove this CUSTOM_PROTOCOLS flag
Pascal Jacquemart
Comment 2 2014-10-09 15:06:04 PDT
Do you think we could safely remove this CUSTOM_PROTOCOLS compilation switch? Shall we ask first on the mailing list if anyone would object? I have serious doubts about the Win bot. Would windows port be affected by this cleanup?
Carlos Garcia Campos
Comment 3 2014-10-09 23:21:37 PDT
Pascal, thanks for working on this. What I'm sure is that we can remove the old soup implementation, which is what this bug is about. So, I would submit a patch here to remove the soup code, and file a new bug report for the flag removal, sending an email to webkit-dev as well, to let everybody know and in case someone may object.
Pascal Jacquemart
Comment 4 2014-10-10 03:19:45 PDT
Created attachment 239614 [details] Remove custom URI schemes implementation At least I am glad to see that all ports can now compile with this CUSTOM_PROTOCOLS flag removal This patch removes old custom URI schemes implementation, still keeping the CUSTOM_PROTOCOLS flag The policy applied is as follow: #if USE(SOUP) && !ENABLE(CUSTOM_PROTOCOLS) -> Remove #if !ENABLE(CUSTOM_PROTOCOLS) inside a soup related file -> Remove #if USE(SOUP) && ENABLE(CUSTOM_PROTOCOLS) -> Keep #if ENABLE(CUSTOM_PROTOCOLS) -> keep
WebKit Commit Bot
Comment 5 2014-10-10 05:49:59 PDT
Comment on attachment 239614 [details] Remove custom URI schemes implementation Clearing flags on attachment: 239614 Committed r174584: <http://trac.webkit.org/changeset/174584>
WebKit Commit Bot
Comment 6 2014-10-10 05:50:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.