| Summary: | [SOUP] Remove custom URI schemes implementation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, gyuyoung.kim, p.jacquemart, rakuco, ryuan.choi, sergio | ||||||
| Priority: | P2 | Keywords: | Soup | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 128177 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Carlos Garcia Campos
2014-02-04 02:27:35 PST
Created attachment 239544 [details]
Checking if we can fully remove this CUSTOM_PROTOCOLS flag
Do you think we could safely remove this CUSTOM_PROTOCOLS compilation switch? Shall we ask first on the mailing list if anyone would object? I have serious doubts about the Win bot. Would windows port be affected by this cleanup? Pascal, thanks for working on this. What I'm sure is that we can remove the old soup implementation, which is what this bug is about. So, I would submit a patch here to remove the soup code, and file a new bug report for the flag removal, sending an email to webkit-dev as well, to let everybody know and in case someone may object. Created attachment 239614 [details]
Remove custom URI schemes implementation
At least I am glad to see that all ports can now compile with this CUSTOM_PROTOCOLS flag removal
This patch removes old custom URI schemes implementation, still keeping the CUSTOM_PROTOCOLS flag
The policy applied is as follow:
#if USE(SOUP) && !ENABLE(CUSTOM_PROTOCOLS) -> Remove
#if !ENABLE(CUSTOM_PROTOCOLS) inside a soup related file -> Remove
#if USE(SOUP) && ENABLE(CUSTOM_PROTOCOLS) -> Keep
#if ENABLE(CUSTOM_PROTOCOLS) -> keep
Comment on attachment 239614 [details] Remove custom URI schemes implementation Clearing flags on attachment: 239614 Committed r174584: <http://trac.webkit.org/changeset/174584> All reviewed patches have been landed. Closing bug. |