Bug 12816

Summary: [s60] Toolbar should be activated only on long keypress
Product: WebKit Reporter: Sriram <sriram.yadavalli>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Critical CC: bradley.morrison, darin
Priority: P2    
Version: 417.x   
Hardware: S60 Hardware   
OS: S60 3rd edition   
Attachments:
Description Flags
3.1 patch for toolbar activation
none
3.1 Patch for toolbar
zalan: review-
3.1 Fix as an Engine feature
bradley.morrison: review-
3.1 patch for toolbar
none
3.1 Patch for toolbar long key press
Sachin.Padma: review+
Toolbar should be activated on long key press in 3.2
Sachin.Padma: review-
3.2 Toolbar long key press Sachin.Padma: review+

Description Sriram 2007-02-19 14:19:27 PST
CR 102-5945
Comment 1 Sriram 2007-02-19 14:22:46 PST
Created attachment 13251 [details]
3.1 patch for toolbar activation

Please review task 14029 for browser ui changes
Comment 2 Sriram 2007-02-19 14:44:17 PST
Created attachment 13254 [details]
3.1 Patch for toolbar

Please review code for task 14029 in Browser ui
Comment 3 zalan 2007-02-19 14:58:30 PST
Comment on attachment 13254 [details]
3.1 Patch for toolbar

it moves toolbar click from client to host.
Comment 4 Sriram 2007-02-19 16:58:52 PST
Created attachment 13257 [details]
3.1 Fix as an Engine feature

Please review this if toolbar activation is an engine feature
Comment 5 Sachin Padma 2007-02-23 07:13:59 PST
Comment on attachment 13257 [details]
3.1 Fix as an Engine feature

r=me
Comment 6 Bradley Morrison 2007-02-23 10:34:30 PST
Comment on attachment 13257 [details]
3.1 Fix as an Engine feature

The Boss Says No: r-
Comment 7 Sachin Padma 2007-02-23 10:35:03 PST
Comment on attachment 13257 [details]
3.1 Fix as an Engine feature

Check either Enter key or move the activation inside the case for enter key
Comment 8 Sriram 2007-02-23 15:03:45 PST
Created attachment 13354 [details]
3.1 patch for toolbar
Comment 9 Sriram 2007-02-23 15:36:52 PST
Created attachment 13355 [details]
3.1 Patch for toolbar long key press
Comment 10 Sachin Padma 2007-02-28 11:31:28 PST
Comment on attachment 13355 [details]
3.1 Patch for toolbar long key press

r=me
Comment 11 Bradley Morrison 2007-02-28 14:23:59 PST
(In reply to comment #10)
> (From update of attachment 13355 [details] [edit])
> r=me
> 

landed at r19913 
Comment 12 Krishna 2007-03-04 17:20:53 PST
Closed.
Comment 13 Sriram 2007-04-19 14:28:46 PDT
Created attachment 14096 [details]
Toolbar should be activated on long key press in 3.2
Comment 14 Sachin Padma 2007-04-30 08:02:39 PDT
Comment on attachment 14096 [details]
Toolbar should be activated on long key press in 3.2

Please attach changelog.
Comment 15 Sriram 2007-04-30 10:34:57 PDT
Created attachment 14275 [details]
3.2 Toolbar long key press
Comment 16 Sachin Padma 2007-05-01 14:56:48 PDT
Comment on attachment 14275 [details]
3.2 Toolbar long key press 

r=me