Bug 128112

Summary: Debugger created JSActivations should account for CodeBlock::framePointerOffsetToGetActivationRegisters()
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128120    
Attachments:
Description Flags
fixed in JSActivation::create(). none

Mark Lam
Reported 2014-02-03 10:53:31 PST
They currently do not. Fix coming.
Attachments
fixed in JSActivation::create(). (2.08 KB, patch)
2014-02-03 11:26 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-02-03 11:26:14 PST
Created attachment 223002 [details] fixed in JSActivation::create().
Geoffrey Garen
Comment 2 2014-02-03 12:25:19 PST
Comment on attachment 223002 [details] fixed in JSActivation::create(). This needs a regression test.
WebKit Commit Bot
Comment 3 2014-02-03 12:54:55 PST
Comment on attachment 223002 [details] fixed in JSActivation::create(). Clearing flags on attachment: 223002 Committed r163322: <http://trac.webkit.org/changeset/163322>
WebKit Commit Bot
Comment 4 2014-02-03 12:54:57 PST
All reviewed patches have been landed. Closing bug.
Mark Lam
Comment 5 2014-02-03 13:22:00 PST
(In reply to comment #2) > This needs a regression test. Will work on regression test at https://bugs.webkit.org/show_bug.cgi?id=128120.
Note You need to log in before you can comment on or make changes to this bug.