Bug 128112

Summary:

Debugger created JSActivations should account for CodeBlock::framePointerOffsetToGetActivationRegisters()

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, ggaren, mhahnenberg, msaboff, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

128120

Attachments:

Description	Flags
fixed in JSActivation::create().	none

Description Mark Lam 2014-02-03 10:53:31 PST

They currently do not.  Fix coming.

Comment 1 Mark Lam 2014-02-03 11:26:14 PST

Created attachment 223002 [details]
fixed in JSActivation::create().

Comment 2 Geoffrey Garen 2014-02-03 12:25:19 PST

Comment on attachment 223002 [details]
fixed in JSActivation::create().

This needs a regression test.

Comment 3 WebKit Commit Bot 2014-02-03 12:54:55 PST

Comment on attachment 223002 [details]
fixed in JSActivation::create().

Clearing flags on attachment: 223002

Committed r163322: <http://trac.webkit.org/changeset/163322>

Comment 4 WebKit Commit Bot 2014-02-03 12:54:57 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Mark Lam 2014-02-03 13:22:00 PST

(In reply to comment #2)
> This needs a regression test.

Will work on regression test at https://bugs.webkit.org/show_bug.cgi?id=128120.