| Summary: | Turn GenGC on | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||||
| Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, buildbot, cmarcelo, commit-queue, ggaren, kling, koivisto, ossy, rniwa | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Mark Hahnenberg
2014-02-03 10:44:49 PST
Created attachment 223008 [details]
Patch
Comment on attachment 223008 [details]
Patch
\o/
Comment on attachment 223008 [details] Patch Attachment 223008 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5653330361581568 New failing tests: http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html Created attachment 223020 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Please file follow-up bugs for known performance issues. (I believe you mentioned a SunSpider regression to me in person.) (In reply to comment #5) > Please file follow-up bugs for known performance issues. (I believe you mentioned a SunSpider regression to me in person.) I filed bug 128129 for the sunspider regression. Comment on attachment 223008 [details] Patch Clearing flags on attachment: 223008 Committed r163330: <http://trac.webkit.org/changeset/163330> All reviewed patches have been landed. Closing bug. Looks like 3% regression on Membuster. Filed bug 128160 and bug 128161 to track Membuster and DYEB regressions. PLT and html5 loading test agree this was ~3% performance regression. (In reply to comment #7) > (From update of attachment 223008 [details]) > Clearing flags on attachment: 223008 > > Committed r163330: <http://trac.webkit.org/changeset/163330> It seems the GenGC has a serious bug, because from this change there are many flaky failures on the Apple Mac bots: - http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29?numbuilds=100 - http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29?numbuilds=100 - http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29?numbuilds=100 Apple Mac EWS bots are broken too because of this regression. Could you fix it as soon as possible please? (In reply to comment #12) > (In reply to comment #7) > > (From update of attachment 223008 [details] [details]) > > Clearing flags on attachment: 223008 > > > > Committed r163330: <http://trac.webkit.org/changeset/163330> > > It seems the GenGC has a serious bug, because from this change > there are many flaky failures on the Apple Mac bots: > - http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29?numbuilds=100 > - http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29?numbuilds=100 > - http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK1%20%28Tests%29?numbuilds=100 > > Apple Mac EWS bots are broken too because of this regression. > > Could you fix it as soon as possible please? My guess is that these flaky tests depend on some object being finalized before the test times out. Technically this is a bad assumption because garbage collection isn't designed to run finalizers before a hard deadline. OTOH, it worked before so we should be able to make it work again. I'm working on a simple patch to fix this. |