| Summary: | WK2: Selection in non editable content is not cleared when navigating to a different page | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||
| Component: | WebKit2 | Assignee: | Enrica Casucci <enrica> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | mitz | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | iPhone / iPad | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Enrica Casucci
2014-02-02 15:07:44 PST
Created attachment 222941 [details]
Patch
Comment on attachment 222941 [details]
Patch
Conceptually it seems wrong to do any work in our override of resignFirstResponder if the superclass implementation is going to return NO. Should we call super first and bail out if it returned NO?
This is not new to this patch, however, so r=me.
(In reply to comment #2) > (From update of attachment 222941 [details]) > Conceptually it seems wrong to do any work in our override of resignFirstResponder if the superclass implementation is going to return NO. Should we call super first and bail out if it returned NO? > > This is not new to this patch, however, so r=me. Thanks for the review! You are probably correct about calling the super class first. I checked the implementation in UIWebDocumentview and there are tasks performed before and other performed after calling [super resignFirstResponder] but no checks are performed on the return value. I will leave it like this for now, but I'll add a comment before landing to remind me to do further investigation. Committed revision 163273. |