Bug 128080

Summary: WebKit Bot Watcher's Dashboard: Teach JSON.load() to interpret third argument as either an option dictionary or a failure callback
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch ap: review+

Description Daniel Bates 2014-02-02 12:55:15 PST
For convenience JSON.load() should accept either a Function object or an Object for the data type of the third argument of JSON.load() such that we can call JSON.load() with following forms:

1. JSON.load("http://www.apple.com", function() {/* success */})
2. JSON.load("http://www.apple.com", function() {/* success */}, {withCredentials: true, ...});
3. JSON.load("http://www.apple.com", function() {/* success */}, function() { /* failure */ })
4. JSON.load("http://www.apple.com", function() {/* success */}, function() {/* failure */}, {withCredentials: true, ...})

Currently JSON.load() can be called with forms: (1), (3), and (4).

As implied above, form (2) makes using JSON.load() more convenient when a failure callback function isn't necessary, but a person wants to pass an option dictionary because a person doesn't need to explicitly pass null or a reference to an empty function for the value of the third argument.
Comment 1 Daniel Bates 2014-02-02 13:04:08 PST
Created attachment 222936 [details]
Comment 2 Daniel Bates 2014-02-03 10:04:18 PST
Committed r163313: <http://trac.webkit.org/changeset/163313>